Skip to content

Do not apply StandaloneRestTestPlugin in StandaloneTestPlugin#86400

Merged
breskeby merged 1 commit intoelastic:masterfrom
breskeby:decouple-standalone-test-staresttest
May 9, 2022
Merged

Do not apply StandaloneRestTestPlugin in StandaloneTestPlugin#86400
breskeby merged 1 commit intoelastic:masterfrom
breskeby:decouple-standalone-test-staresttest

Conversation

@breskeby
Copy link
Copy Markdown
Contributor

@breskeby breskeby commented May 3, 2022

As we are moving away from StandaloneRestTestPlugin (see #85491) we want to reduce the surface of that plugin.
If rest tests are used a rest test related plugin should be applied

As we are moving away from StandaloneRestTestPlugin (see elastic#85491) we want to reduce the surface of that plugin.
If rest tests are used a rest test related plugin should be applied
@breskeby breskeby self-assigned this May 3, 2022
@breskeby breskeby added :Delivery/Build Build or test infrastructure >enhancement Team:Delivery Meta label for Delivery team v7.17.4 labels May 3, 2022
@breskeby breskeby marked this pull request as ready for review May 3, 2022 18:13
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

Copy link
Copy Markdown
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to move away from this plugin as well, right? I mean, I'm pretty sure we could just swap this out for the elasticsearch.java plugin everywhere and it would just work. The only side-effect is we would be creating a main sourceset that doens't have any source in it and so those tasks would be noops. Do you intend to do this in a follow up PR?

@breskeby
Copy link
Copy Markdown
Contributor Author

breskeby commented May 5, 2022

Long term yes but at the moment, elasticsearch.java is still doing a bit too much for a test only project imo as it also applies plugins, adds a lot unneeded task configurations. After we removed elasticsearch.rest-test and standalone-rest-test we can look into this. I think we might want something like production vs. qa plugins to differ between production code intended to be shipped and qa projects.

@breskeby breskeby merged commit a50ab96 into elastic:master May 9, 2022
breskeby added a commit to breskeby/elasticsearch that referenced this pull request May 9, 2022
…c#86400)

As we are moving away from StandaloneRestTestPlugin (see elastic#85491) we want to reduce the surface of that plugin.
If rest tests are used a rest test related plugin should be applied
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

💚 Backport successful

Status Branch Result
7.17

elasticsearchmachine pushed a commit that referenced this pull request May 9, 2022
…86400) (#86563)

* Do not apply StandaloneRestTestPlugin in StandaloneTestPlugin (#86400)

As we are moving away from StandaloneRestTestPlugin (see #85491) we want to reduce the surface of that plugin.
If rest tests are used a rest test related plugin should be applied

* Fix translog-policy build relying on standalone rest test plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Delivery/Build Build or test infrastructure >enhancement Team:Delivery Meta label for Delivery team v7.17.4 v8.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants