Remove elasticsearch.rest-test gradle plugin by breskeby · Pull Request #85491 · elastic/elasticsearch

breskeby · 2022-03-30T11:04:52Z

Removes and remaining usages of elasticsearch.rest-test and the plugin itself from the codebase

Relates to #63696

As we are moving away from StandaloneRestTestPlugin (see elastic#85491) we want to reduce the surface of that plugin. If rest tests are used a rest test related plugin should be applied

As we are moving away from StandaloneRestTestPlugin (see #85491) we want to reduce the surface of that plugin. If rest tests are used a rest test related plugin should be applied

…st plugin - Use internal java rest test or internal yaml rest test plugin instead This is part of elastic#85491

…st plugin (#86626) - Use internal java rest test or internal yaml rest test plugin instead This is part of #85491

…st plugin (elastic#86626) - Use internal java rest test or internal yaml rest test plugin instead This is part of elastic#85491 # Conflicts: # qa/snapshot-based-recoveries/azure/src/test/java/org/elasticsearch/recovery/AzureSnapshotBasedRecoveryIT.java # qa/snapshot-based-recoveries/gcs/src/test/java/org/elasticsearch/recovery/GCSSnapshotBasedRecoveryIT.java # qa/snapshot-based-recoveries/s3/src/test/java/org/elasticsearch/recovery/S3SnapshotBasedRecoveryIT.java # x-pack/plugin/repositories-metering-api/qa/azure/build.gradle # x-pack/plugin/repositories-metering-api/qa/gcs/build.gradle # x-pack/plugin/repositories-metering-api/qa/s3/build.gradle # x-pack/plugin/searchable-snapshots/qa/azure/build.gradle # x-pack/plugin/searchable-snapshots/qa/gcs/build.gradle # x-pack/plugin/searchable-snapshots/qa/minio/build.gradle # x-pack/plugin/searchable-snapshots/qa/s3/build.gradle # x-pack/plugin/snapshot-based-recoveries/qa/azure/build.gradle # x-pack/plugin/snapshot-based-recoveries/qa/azure/src/javaRestTest/java/org/elasticsearch/xpack/snapshotbasedrecoveries/recovery/AzureSnapshotBasedRecoveryIT.java # x-pack/plugin/snapshot-based-recoveries/qa/azure/src/test/java/org/elasticsearch/xpack/snapshotbasedrecoveries/recovery/AzureSnapshotBasedRecoveryIT.java # x-pack/plugin/snapshot-based-recoveries/qa/fs/build.gradle # x-pack/plugin/snapshot-based-recoveries/qa/fs/src/javaRestTest/java/org/elasticsearch/xpack/snapshotbasedrecoveries/recovery/FsSnapshotBasedRecoveryIT.java # x-pack/plugin/snapshot-based-recoveries/qa/gcs/build.gradle # x-pack/plugin/snapshot-based-recoveries/qa/gcs/src/javaRestTest/java/org/elasticsearch/xpack/snapshotbasedrecoveries/recovery/GCSSnapshotBasedRecoveryIT.java # x-pack/plugin/snapshot-based-recoveries/qa/gcs/src/test/java/org/elasticsearch/xpack/snapshotbasedrecoveries/recovery/GCSSnapshotBasedRecoveryIT.java # x-pack/plugin/snapshot-based-recoveries/qa/license-enforcing/build.gradle # x-pack/plugin/snapshot-based-recoveries/qa/license-enforcing/src/javaRestTest/java/org/elasticsearch/xpack/snapshotbasedrecoveries/recovery/LicenseIsEnforcedDuringSnapshotBasedRecoveryIT.java # x-pack/plugin/snapshot-based-recoveries/qa/s3/build.gradle # x-pack/plugin/snapshot-based-recoveries/qa/s3/src/javaRestTest/java/org/elasticsearch/xpack/snapshotbasedrecoveries/recovery/S3SnapshotBasedRecoveryIT.java # x-pack/plugin/snapshot-based-recoveries/qa/s3/src/test/java/org/elasticsearch/xpack/snapshotbasedrecoveries/recovery/S3SnapshotBasedRecoveryIT.java # x-pack/plugin/snapshot-repo-test-kit/qa/azure/build.gradle # x-pack/plugin/snapshot-repo-test-kit/qa/gcs/build.gradle # x-pack/plugin/snapshot-repo-test-kit/qa/minio/build.gradle # x-pack/plugin/snapshot-repo-test-kit/qa/s3/build.gradle # x-pack/plugin/sql/qa/jdbc/build.gradle # x-pack/plugin/sql/qa/jdbc/single-node/src/javaRestTest/java/org/elasticsearch/xpack/sql/qa/jdbc/single_node/JdbcCloseCursorIT.java # x-pack/plugin/sql/qa/jdbc/single-node/src/javaRestTest/java/org/elasticsearch/xpack/sql/qa/jdbc/single_node/JdbcWarningsIT.java # x-pack/plugin/sql/qa/server/multi-node/src/javaRestTest/java/org/elasticsearch/xpack/sql/qa/multi_node/CliLenientIT.java # x-pack/plugin/sql/qa/server/security/build.gradle # x-pack/plugin/sql/qa/server/single-node/build.gradle # x-pack/plugin/sql/qa/server/single-node/src/javaRestTest/java/org/elasticsearch/xpack/sql/qa/single_node/CliLenientIT.java # x-pack/plugin/sql/qa/server/single-node/src/javaRestTest/java/org/elasticsearch/xpack/sql/qa/single_node/RestSqlDeprecationIT.java # x-pack/plugin/sql/qa/server/single-node/src/javaRestTest/java/org/elasticsearch/xpack/sql/qa/single_node/RestSqlPaginationIT.java # x-pack/plugin/sql/qa/server/src/main/java/org/elasticsearch/xpack/sql/qa/rest/RestSqlTestCase.java # x-pack/plugin/sql/qa/server/src/main/resources/command.csv-spec # x-pack/plugin/sql/qa/server/src/main/resources/single-node-only/command-sys.csv-spec # x-pack/plugin/sql/qa/server/src/main/resources/slow/frozen.csv-spec # x-pack/plugin/vector-tile/qa/multi-cluster/build.gradle

elasticmachine · 2022-05-12T17:23:52Z

Pinging @elastic/es-delivery (Team:Delivery)

This reverts commit 06341f0.

pugnascotia · 2022-05-16T08:22:12Z

...oip/qa/file-based-update/src/test/java/org/elasticsearch/ingest/geoip/UpdateDatabasesIT.java

-import static org.hamcrest.Matchers.notNullValue;
-import static org.hamcrest.Matchers.nullValue;
-
-public class UpdateDatabasesIT extends ESRestTestCase {


Why is this file deleted?

Same with the database file itself. Perhaps we inteded to move these?

they have been moved in an earlier pr 🤦 so this is basically a cleanup

mark-vieira

I think that geoip test got mistakenly removed, otherwise LGTM.

mark-vieira · 2022-05-16T17:37:04Z

...oip/qa/file-based-update/src/test/java/org/elasticsearch/ingest/geoip/UpdateDatabasesIT.java

-import static org.hamcrest.Matchers.notNullValue;
-import static org.hamcrest.Matchers.nullValue;
-
-public class UpdateDatabasesIT extends ESRestTestCase {


Same with the database file itself. Perhaps we inteded to move these?

breskeby · 2022-05-17T09:03:51Z

I accidentally have moved the files in an earlier commit but didn't delete the old location. I'll fix this up

Removes and remaining usages of `elasticsearch.rest-test` and the plugin itself from the codebase Relates to elastic#63696 # Conflicts: # build-tools-internal/build.gradle # modules/ingest-geoip/qa/file-based-update/src/test/java/org/elasticsearch/ingest/geoip/UpdateDatabasesIT.java

Backports the following commits to 7.17: - Remove elasticsearch.rest-test gradle plugin (#85491)

breskeby self-assigned this Mar 30, 2022

breskeby added :Delivery/Build Build or test infrastructure >enhancement Team:Delivery Meta label for Delivery team v7.17.3 v8.1.2 v8.2.0 labels Mar 30, 2022

salvatore-campagna added v8.3.0 and removed v8.2.0 labels Mar 30, 2022

breskeby changed the title ~~Replace elasticsearch.java-rest with elasticsearch.internal-yaml-test where possible~~ Replace elasticsearch.java-rest with elasticsearch.internal-yaml-test Apr 19, 2022

breskeby changed the title ~~Replace elasticsearch.java-rest with elasticsearch.internal-yaml-test~~ Deprecate elasticsearch.java-rest Apr 19, 2022

breskeby force-pushed the replace-rest-test-with-iyt branch from d477de3 to 47982e7 Compare April 19, 2022 09:26

breskeby changed the title ~~Deprecate elasticsearch.java-rest~~ Deprecate elasticsearch.rest-test plugin Apr 19, 2022

breskeby changed the title ~~Deprecate elasticsearch.rest-test plugin~~ Deprecate elasticsearch.rest-test gradle plugin Apr 19, 2022

breskeby force-pushed the replace-rest-test-with-iyt branch 3 times, most recently from 96b76a0 to 3e498ec Compare April 25, 2022 12:55

breskeby force-pushed the replace-rest-test-with-iyt branch 3 times, most recently from 49556e8 to 804f91f Compare May 3, 2022 11:30

breskeby mentioned this pull request May 3, 2022

Do not apply StandaloneRestTestPlugin in StandaloneTestPlugin #86400

Merged

breskeby force-pushed the replace-rest-test-with-iyt branch 6 times, most recently from 5bbefc6 to fb8e937 Compare May 9, 2022 10:33

breskeby mentioned this pull request May 9, 2022

Port xpack qa projects away from elasticsearch rest test gradle plugin #86562

Merged

breskeby mentioned this pull request May 10, 2022

Port all remaining xpack plugin projects away from deprecated rest-test plugin #86626

Merged

breskeby added a commit to breskeby/elasticsearch that referenced this pull request May 11, 2022

Port all remaining xpack plugin projects away from deprecated rest-te…

0da84a8

…st plugin - Use internal java rest test or internal yaml rest test plugin instead This is part of elastic#85491

breskeby added a commit that referenced this pull request May 11, 2022

Port all remaining xpack plugin projects away from deprecated rest-te…

a10cc8d

…st plugin (#86626) - Use internal java rest test or internal yaml rest test plugin instead This is part of #85491

breskeby force-pushed the replace-rest-test-with-iyt branch 2 times, most recently from 8f03698 to cfc4226 Compare May 11, 2022 19:04

breskeby force-pushed the replace-rest-test-with-iyt branch 2 times, most recently from d90c605 to 7c6b4fa Compare May 12, 2022 10:32

breskeby changed the title ~~Deprecate elasticsearch.rest-test gradle plugin~~ Remove elasticsearch.rest-test gradle plugin May 12, 2022

breskeby force-pushed the replace-rest-test-with-iyt branch from 7c6b4fa to 6ea9525 Compare May 12, 2022 16:08

breskeby marked this pull request as ready for review May 12, 2022 17:23

breskeby force-pushed the replace-rest-test-with-iyt branch from 6ea9525 to fd3fd84 Compare May 12, 2022 17:30

breskeby removed the v8.1.2 label May 12, 2022

breskeby added 4 commits May 16, 2022 07:42

Merge conflict when rebasing

dcaf314

Do not remove StandaloneRestTestPlugin yet

eea42ee

Fix docker distribution rest tests

5aff2be

Revert "Remove accidentally added files not in use yet"

6d052f2

This reverts commit 06341f0.

breskeby force-pushed the replace-rest-test-with-iyt branch from 018af00 to 6d052f2 Compare May 16, 2022 05:44

breskeby requested review from mark-vieira and pugnascotia May 16, 2022 07:59

pugnascotia reviewed May 16, 2022

View reviewed changes

mark-vieira approved these changes May 16, 2022

View reviewed changes

breskeby merged commit bf4304d into elastic:master May 17, 2022

breskeby deleted the replace-rest-test-with-iyt branch May 17, 2022 09:23

breskeby mentioned this pull request May 23, 2022

[7.17] Remove elasticsearch.rest-test gradle plugin (#85491) #87025

Merged

breskeby added a commit that referenced this pull request May 23, 2022

[7.17] Remove elasticsearch.rest-test gradle plugin (#85491) (#87025)

9153760

Backports the following commits to 7.17: - Remove elasticsearch.rest-test gradle plugin (#85491)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove elasticsearch.rest-test gradle plugin#85491

Remove elasticsearch.rest-test gradle plugin#85491
breskeby merged 4 commits intoelastic:masterfrom
breskeby:replace-rest-test-with-iyt

breskeby commented Mar 30, 2022 •

edited

Loading

Uh oh!

elasticmachine commented May 12, 2022

Uh oh!

pugnascotia May 16, 2022

Uh oh!

mark-vieira May 16, 2022

Uh oh!

breskeby May 17, 2022

Uh oh!

mark-vieira left a comment

Uh oh!

mark-vieira May 16, 2022

Uh oh!

breskeby commented May 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

breskeby commented Mar 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented May 12, 2022

Uh oh!

pugnascotia May 16, 2022

Choose a reason for hiding this comment

Uh oh!

mark-vieira May 16, 2022

Choose a reason for hiding this comment

Uh oh!

breskeby May 17, 2022

Choose a reason for hiding this comment

Uh oh!

mark-vieira left a comment

Choose a reason for hiding this comment

Uh oh!

mark-vieira May 16, 2022

Choose a reason for hiding this comment

Uh oh!

breskeby commented May 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

breskeby commented Mar 30, 2022 •

edited

Loading