Reject openConnection attempt while closing#86315
Merged
DaveCTurner merged 2 commits intoelastic:masterfrom May 2, 2022
Merged
Reject openConnection attempt while closing#86315DaveCTurner merged 2 commits intoelastic:masterfrom
DaveCTurner merged 2 commits intoelastic:masterfrom
Conversation
Today while the `ClusterConnectionManager` is closing it will reject attempts to open _managed_ connections (i.e. using `connectToNode`), but it still permits ad-hoc connections (i.e. using `openConnection`). This commit extends the existing refcounting mechanism to cover both cases, preventing all concurrent connection attempts while shutting down. Closes elastic#86249 Relates elastic#77539
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Collaborator
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
Member
Author
|
In some sense this is the wrong place to apply this fix: it would also work to address this in |
idegtiarenko
approved these changes
May 2, 2022
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 17, 2022
We introduced an assertion in elastic#85131 to check the assumption that there are no pending non-local response handlers when the `TransportService` shuts down. We later discovered that this assertion rarely tripped, which we fixed in elastic#86315, but that fix did not go into 8.2 so there are still rare failures on this branch. This commit drops the faulty assertion in 8.2. Relates elastic#86293
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 17, 2022
We introduced an assertion in #85131 to check the assumption that there are no pending non-local response handlers when the `TransportService` shuts down. We later discovered that this assertion rarely tripped, which we fixed in #86315, but that fix did not go into 8.2 so there are still rare failures on this branch. This commit drops the faulty assertion in 8.2. Relates #86293
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today while the
ClusterConnectionManageris closing it will rejectattempts to open managed connections (i.e. using
connectToNode), butit still permits ad-hoc connections (i.e. using
openConnection). Thiscommit extends the existing refcounting mechanism to cover both cases,
preventing all concurrent connection attempts while shutting down.
Closes #86249
Relates #77539