Drop faulty assertion in TransportService#86843
Merged
elasticsearchmachine merged 1 commit intoelastic:8.2from May 17, 2022
Merged
Conversation
We introduced an assertion in elastic#85131 to check the assumption that there are no pending non-local response handlers when the `TransportService` shuts down. We later discovered that this assertion rarely tripped, which we fixed in elastic#86315, but that fix did not go into 8.2 so there are still rare failures on this branch. This commit drops the faulty assertion in 8.2. Relates elastic#86293
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
original-brownbear
approved these changes
May 17, 2022
idegtiarenko
approved these changes
May 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We introduced an assertion in #85131 to check the assumption that there
are no pending non-local response handlers when the
TransportServiceshuts down. We later discovered that this assertion rarely tripped,
which we fixed in #86315, but that fix did not go into 8.2 so there are
still rare failures on this branch. This commit drops the faulty
assertion in 8.2.
Relates #86293