Discard intermediate results upon cancellation for stats endpoints#82685
Merged
gmarouli merged 31 commits intoelastic:masterfrom Feb 10, 2022
Merged
Conversation
Contributor
Author
|
@elasticsearchmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
This will allow us to isolate testing and argue about races
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-tests-unix-sample |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/part-1 |
dakrone
approved these changes
Feb 4, 2022
Member
dakrone
left a comment
There was a problem hiding this comment.
This generally looks good to me, I left an optional comment
server/src/main/java/org/elasticsearch/action/support/NodeResponseTracker.java
Outdated
Show resolved
Hide resolved
dakrone
reviewed
Feb 7, 2022
server/src/main/java/org/elasticsearch/action/support/NodeResponseTracker.java
Outdated
Show resolved
Hide resolved
gmarouli
commented
Feb 9, 2022
DaveCTurner
reviewed
Feb 9, 2022
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
Looks good @gmarouli, I left a handful of small comments.
server/src/main/java/org/elasticsearch/tasks/CancellableTask.java
Outdated
Show resolved
Hide resolved
...ain/java/org/elasticsearch/action/support/broadcast/node/TransportBroadcastByNodeAction.java
Outdated
Show resolved
Hide resolved
...ain/java/org/elasticsearch/action/support/broadcast/node/TransportBroadcastByNodeAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/support/NodeResponseTracker.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/support/NodeResponseTracker.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@dakrone & @DaveCTurner Thank you very much for your comments! |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-tests-unix-sample |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-tests-windows-sample |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/bwc |
This was referenced Jan 17, 2023
This was referenced Oct 23, 2023
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Oct 23, 2023
Today we rely on an `isRunning` check to check for task cancellation, but since elastic#82685 we can actively record the failure arising from the cancellation using a `CancellationListener`. Closes elastic#101197
DaveCTurner
added a commit
that referenced
this pull request
Oct 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discard intermediate results when a stats request is cancelled.
Next tasks:
_cluster/staterequestResolves #82337