Improve cancellation in repo analysis#101213
Merged
DaveCTurner merged 1 commit intoelastic:mainfrom Oct 24, 2023
Merged
Conversation
Today we rely on an `isRunning` check to check for task cancellation, but since elastic#82685 we can actively record the failure arising from the cancellation using a `CancellationListener`. Closes elastic#101197
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today we rely on an
isRunningcheck to check for task cancellation,but since #82685 we can actively record the failure arising from the
cancellation using a
CancellationListener.Closes #101197