Fix after restore Lucene.pruneUnreferencedFiles() conditional#81047
Merged
tlrx merged 1 commit intoelastic:masterfrom Nov 25, 2021
Merged
Fix after restore Lucene.pruneUnreferencedFiles() conditional#81047tlrx merged 1 commit intoelastic:masterfrom
tlrx merged 1 commit intoelastic:masterfrom
Conversation
ywelsch
approved these changes
Nov 25, 2021
Contributor
ywelsch
left a comment
There was a problem hiding this comment.
LGTM. I will follow-up with a change to remove this logic altogether
Member
Author
|
Thanks Yannick! |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Nov 25, 2021
…c#81047) In elastic#68821 we introduced a condition to skip the pruning of unreferenced files after the restore of a snapshot for searchable snapshot shards. Sadly I managed to mess this up in a refactoring (elastic#75308) few months after. This commit reintroduces the right conditional which is to NOT prune Lucene files for searchable snapshot shards.
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Nov 25, 2021
…c#81047) In elastic#68821 we introduced a condition to skip the pruning of unreferenced files after the restore of a snapshot for searchable snapshot shards. Sadly I managed to mess this up in a refactoring (elastic#75308) few months after. This commit reintroduces the right conditional which is to NOT prune Lucene files for searchable snapshot shards.
Collaborator
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 25, 2021
#81051) In #68821 we introduced a condition to skip the pruning of unreferenced files after the restore of a snapshot for searchable snapshot shards. Sadly I managed to mess this up in a refactoring (#75308) few months after. This commit reintroduces the right conditional which is to NOT prune Lucene files for searchable snapshot shards.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 26, 2021
#81050) In #68821 we introduced a condition to skip the pruning of unreferenced files after the restore of a snapshot for searchable snapshot shards. Sadly I managed to mess this up in a refactoring (#75308) few months after. This commit reintroduces the right conditional which is to NOT prune Lucene files for searchable snapshot shards. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #68821 we introduced a condition to skip the pruning of unreferenced files after the restore of a snapshot for searchable snapshot shards. Sadly I managed to mess this up in a refactoring (#75308) few months after.
This commit reintroduces the right conditional which is to NOT prune Lucene files for searchable snapshot shards.