Move some constants from SearchableSnapshotsConstants to server#75308
Merged
tlrx merged 1 commit intoelastic:masterfrom Jul 15, 2021
Merged
Move some constants from SearchableSnapshotsConstants to server#75308tlrx merged 1 commit intoelastic:masterfrom
tlrx merged 1 commit intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
tlrx
commented
Jul 13, 2021
| public class SearchableSnapshotsConstants { | ||
| public static final String SNAPSHOT_DIRECTORY_FACTORY_KEY = "snapshot"; | ||
|
|
||
| public static final String SNAPSHOT_RECOVERY_STATE_FACTORY_KEY = "snapshot_prewarm"; |
Member
Author
There was a problem hiding this comment.
This has been removed from x-pack core and placed into the searchable snapshot plugin instead.
tlrx
commented
Jul 13, 2021
Comment on lines
-50
to
-58
| public static final String CACHE_FETCH_ASYNC_THREAD_POOL_NAME = "searchable_snapshots_cache_fetch_async"; | ||
| public static final String CACHE_FETCH_ASYNC_THREAD_POOL_SETTING = "xpack.searchable_snapshots.cache_fetch_async_thread_pool"; | ||
|
|
||
| public static final String CACHE_PREWARMING_THREAD_POOL_NAME = "searchable_snapshots_cache_prewarming"; | ||
| public static final String CACHE_PREWARMING_THREAD_POOL_SETTING = "xpack.searchable_snapshots.cache_prewarming_thread_pool"; | ||
|
|
||
| public static final String SNAPSHOT_BLOB_CACHE_INDEX = ".snapshot-blob-cache"; | ||
|
|
||
| public static final Version SHARED_CACHE_VERSION = Version.V_7_12_0; |
Member
Author
There was a problem hiding this comment.
This has been removed from x-pack core and placed into the searchable snapshot plugin instead.
DaveCTurner
reviewed
Jul 13, 2021
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM assuming CI is happy 👍
| assertThat(DataTierAllocationDecider.INDEX_ROUTING_PREFER_SETTING.get(settings), equalTo(DATA_FROZEN)); | ||
| } | ||
|
|
||
| private ClusterState prepareState(ClusterState initialState) { |
Member
There was a problem hiding this comment.
These seem to be used in 7.x still, backport beware :)
DaveCTurner
approved these changes
Jul 13, 2021
Member
Author
|
Thanks David! |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Jul 15, 2021
…tic#75308) Elasticsearch's server sometimes has to do things differently in order to handle searchable snapshots shards. In such cases it relies on index settings and hard coded values to know if a shard is a searchable snapshot one. This commit adds a new SearchableSnapshotsSettings class in server that provides methods to check if an index is a searchable snapshot index. This class also contains the names of some index settings related to searchable snapshots that are required by the server.
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Jul 15, 2021
…tic#75308) Elasticsearch's server sometimes has to do things differently in order to handle searchable snapshots shards. In such cases it relies on index settings and hard coded values to know if a shard is a searchable snapshot one. This commit adds a new SearchableSnapshotsSettings class in server that provides methods to check if an index is a searchable snapshot index. This class also contains the names of some index settings related to searchable snapshots that are required by the server.
tlrx
added a commit
that referenced
this pull request
Jul 15, 2021
…#75365) Elasticsearch's server sometimes has to do things differently in order to handle searchable snapshots shards. In such cases it relies on index settings and hard coded values to know if a shard is a searchable snapshot one. This commit adds a new SearchableSnapshotsSettings class in server that provides methods to check if an index is a searchable snapshot index. This class also contains the names of some index settings related to searchable snapshots that are required by the server. Backport of #75308
tlrx
added a commit
that referenced
this pull request
Jul 15, 2021
#75366) Elasticsearch's server sometimes has to do things differently in order to handle searchable snapshots shards. In such cases it relies on index settings and hard coded values to know if a shard is a searchable snapshot one. This commit adds a new SearchableSnapshotsSettings class in server that provides methods to check if an index is a searchable snapshot index. This class also contains the names of some index settings related to searchable snapshots that are required by the server. Backport of #75308
masseyke
pushed a commit
to masseyke/elasticsearch
that referenced
this pull request
Jul 16, 2021
…tic#75308) Elasticsearch's server sometimes has to do things differently in order to handle searchable snapshots shards. In such cases it relies on index settings and hard coded values to know if a shard is a searchable snapshot one. This commit adds a new SearchableSnapshotsSettings class in server that provides methods to check if an index is a searchable snapshot index. This class also contains the names of some index settings related to searchable snapshots that are required by the server.
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 30, 2021
…tic#75308) Elasticsearch's server sometimes has to do things differently in order to handle searchable snapshots shards. In such cases it relies on index settings and hard coded values to know if a shard is a searchable snapshot one. This commit adds a new SearchableSnapshotsSettings class in server that provides methods to check if an index is a searchable snapshot index. This class also contains the names of some index settings related to searchable snapshots that are required by the server.
tlrx
added a commit
that referenced
this pull request
Nov 25, 2021
In #68821 we introduced a condition to skip the pruning of unreferenced files after the restore of a snapshot for searchable snapshot shards. Sadly I managed to mess this up in a refactoring (#75308) few months after. This commit reintroduces the right conditional which is to NOT prune Lucene files for searchable snapshot shards.
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Nov 25, 2021
…c#81047) In elastic#68821 we introduced a condition to skip the pruning of unreferenced files after the restore of a snapshot for searchable snapshot shards. Sadly I managed to mess this up in a refactoring (elastic#75308) few months after. This commit reintroduces the right conditional which is to NOT prune Lucene files for searchable snapshot shards.
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Nov 25, 2021
…c#81047) In elastic#68821 we introduced a condition to skip the pruning of unreferenced files after the restore of a snapshot for searchable snapshot shards. Sadly I managed to mess this up in a refactoring (elastic#75308) few months after. This commit reintroduces the right conditional which is to NOT prune Lucene files for searchable snapshot shards.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 25, 2021
#81051) In #68821 we introduced a condition to skip the pruning of unreferenced files after the restore of a snapshot for searchable snapshot shards. Sadly I managed to mess this up in a refactoring (#75308) few months after. This commit reintroduces the right conditional which is to NOT prune Lucene files for searchable snapshot shards.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 26, 2021
#81050) In #68821 we introduced a condition to skip the pruning of unreferenced files after the restore of a snapshot for searchable snapshot shards. Sadly I managed to mess this up in a refactoring (#75308) few months after. This commit reintroduces the right conditional which is to NOT prune Lucene files for searchable snapshot shards. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elasticsearch's server sometimes has to do things differently in order to handle searchable snapshots shards. In such cases it relies on index settings and hard coded values to know if a shard is a searchable snapshot one.
This pull request adds a new
SearchableSnapshotsSettingsclass inserverthat provides methods to check if an index is a searchable snapshot index. This class also contains the names of some index settings related to searchable snapshots that are required by the server.