[ML] Set parent task when calling infer action from internal infer#80731
Merged
dimitris-athanasiou merged 1 commit intoelastic:masterfrom Nov 16, 2021
Conversation
This commit sets the parent task id to the trained model infer action when it is called from the internal infer action (ingest use case).
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
benwtrent
approved these changes
Nov 15, 2021
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Nov 16, 2021
…lastic#80731) This commit sets the parent task id to the trained model infer action when it is called from the internal infer action (ingest use case).
davidkyle
reviewed
Nov 16, 2021
| request.setParentTaskId(taskId); | ||
| executeAsyncWithOrigin( | ||
| client, | ||
| new ParentTaskAssigningClient(client, taskId), |
Member
There was a problem hiding this comment.
ParentTaskAssigningClient calls request.setParentTaskId(taskId); exactly as you have done in line 193 you should either set request.setParentTaskId(taskId); yourself or use the ParentTaskAssigningClient not both.
Contributor
Author
There was a problem hiding this comment.
I tried that at first. When the internal infer calls the trained model infer action, two tasks are created for the trained model infer action. One tagged with [n] for node level and another one. If I don't use a ParentTaskAssigningClient the node task is not parented properly.
Contributor
Author
There was a problem hiding this comment.
Actually, I revisited this. From testing it seems that setting the parent task id on the request has no effect. Only when calling with the ParentTaskAssigningClient the result task is parented correctly. I'll follow up with a PR to remove setting the parent task id on the request.
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Nov 22, 2021
In elastic#80731 the infer trained model task was correctly set to have as parent task the internal infer action task when called from there. However, it was done by both setting `Request.setParentTaskId` and using a `ParentTaskAssigningClient`. There is no need to use a parent task client. Instead, to set the parent task on the request we should use `setParentTask` instead of `setParentTaskId` which effectively sets the target task for a `BaseTasksRequest`. The confusion of `BaseTasksRequest` holding two fields both names `parentTaskId` and having two methods both setting the parent task id will be addressed in a separate PR.
dimitris-athanasiou
added a commit
that referenced
this pull request
Nov 23, 2021
…80905) In #80731 the infer trained model task was correctly set to have as parent task the internal infer action task when called from there. However, it was done by both setting `Request.setParentTaskId` and using a `ParentTaskAssigningClient`. There is no need to use a parent task client. Instead, to set the parent task on the request we should use `setParentTask` instead of `setParentTaskId` which effectively sets the target task for a `BaseTasksRequest`. The confusion of `BaseTasksRequest` holding two fields both names `parentTaskId` and having two methods both setting the parent task id will be addressed in a separate PR. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Nov 23, 2021
…lastic#80905) In elastic#80731 the infer trained model task was correctly set to have as parent task the internal infer action task when called from there. However, it was done by both setting `Request.setParentTaskId` and using a `ParentTaskAssigningClient`. There is no need to use a parent task client. Instead, to set the parent task on the request we should use `setParentTask` instead of `setParentTaskId` which effectively sets the target task for a `BaseTasksRequest`. The confusion of `BaseTasksRequest` holding two fields both names `parentTaskId` and having two methods both setting the parent task id will be addressed in a separate PR. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 23, 2021
…80905) (#80934) In #80731 the infer trained model task was correctly set to have as parent task the internal infer action task when called from there. However, it was done by both setting `Request.setParentTaskId` and using a `ParentTaskAssigningClient`. There is no need to use a parent task client. Instead, to set the parent task on the request we should use `setParentTask` instead of `setParentTaskId` which effectively sets the target task for a `BaseTasksRequest`. The confusion of `BaseTasksRequest` holding two fields both names `parentTaskId` and having two methods both setting the parent task id will be addressed in a separate PR. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit sets the parent task id to the trained model infer action
when it is called from the internal infer action (ingest use case).