Skip to content

[8.0] [ML] No need to use parent task client when internal infer delegates (#80905)#80934

Merged
elasticsearchmachine merged 1 commit intoelastic:8.0from
dimitris-athanasiou:backport/8.0/pr-80905
Nov 23, 2021
Merged

[8.0] [ML] No need to use parent task client when internal infer delegates (#80905)#80934
elasticsearchmachine merged 1 commit intoelastic:8.0from
dimitris-athanasiou:backport/8.0/pr-80905

Conversation

@dimitris-athanasiou
Copy link
Copy Markdown
Contributor

Backports the following commits to 8.0:

…lastic#80905)

In elastic#80731 the infer trained model task was correctly set to have as
parent task the internal infer action task when called from there.
However, it was done by both setting `Request.setParentTaskId` and
using a `ParentTaskAssigningClient`. There is no need to use a
parent task client. Instead, to set the parent task on the request
we should use `setParentTask` instead of `setParentTaskId` which
effectively sets the target task for a `BaseTasksRequest`.

The confusion of `BaseTasksRequest` holding two fields both names
`parentTaskId` and having two methods both setting the parent task
id will be addressed in a separate PR.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@dimitris-athanasiou dimitris-athanasiou added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport labels Nov 23, 2021
@elasticsearchmachine elasticsearchmachine merged commit c7a8f88 into elastic:8.0 Nov 23, 2021
@dimitris-athanasiou dimitris-athanasiou deleted the backport/8.0/pr-80905 branch November 23, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants