Changing HeaderWarning to always use 299 as the warning code#80304
Merged
masseyke merged 4 commits intoelastic:masterfrom Nov 8, 2021
Merged
Conversation
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Member
Author
|
@elasticmachine run elasticsearch-ci/part-2 |
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Nov 8, 2021
…#80304) This commit changes the deprecation logger so that all messages (critical or warning) are written out with "299" as the level at the beginning of the header in order to be compliant with https://www.rfc-editor.org/rfc/rfc7234.html#section-5.5.7. In elastic#79107 we mistakenly began logging warning-level messages with the 300 code, which is not valid in the RFC.
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Nov 8, 2021
…#80304) This commit changes the deprecation logger so that all messages (critical or warning) are written out with "299" as the level at the beginning of the header in order to be compliant with https://www.rfc-editor.org/rfc/rfc7234.html#section-5.5.7. In elastic#79107 we mistakenly began logging warning-level messages with the 300 code, which is not valid in the RFC.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 8, 2021
…#80501) This commit changes the deprecation logger so that all messages (critical or warning) are written out with "299" as the level at the beginning of the header in order to be compliant with https://www.rfc-editor.org/rfc/rfc7234.html#section-5.5.7. In #79107 we mistakenly began logging warning-level messages with the 300 code, which is not valid in the RFC.
masseyke
added a commit
that referenced
this pull request
Nov 8, 2021
…#80503) * Changing HeaderWarning to always use 299 as the warning code (#80304) This commit changes the deprecation logger so that all messages (critical or warning) are written out with "299" as the level at the beginning of the header in order to be compliant with https://www.rfc-editor.org/rfc/rfc7234.html#section-5.5.7. In #79107 we mistakenly began logging warning-level messages with the 300 code, which is not valid in the RFC. * fixing compilation errors from merge
This was referenced Dec 1, 2021
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Mar 13, 2025
…warning This setting is not getting removed in ES 9.0, so its usage should not generate a critical deprecation warning. `TransportServiceLifecycleTests` already uses `assertWarnings` instead of `assertCriticalWarnings` and we don't distinguish between warning levels in assertions (See elastic#80304) See elastic#109236 See ES-11224
arteam
added a commit
that referenced
this pull request
Mar 14, 2025
…warning (#124788) This setting is not getting removed in ES 9.0, so its usage should not generate a critical deprecation warning. `TransportServiceLifecycleTests` already uses `assertWarnings` instead of `assertCriticalWarnings` and we don't distinguish between warning levels in assertions (See #80304) See #109236 See ES-11224
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the deprecation logger so that all messages (critical or warning) are written out with "299" as
the level at the beginning of the header in order to be compliant with
https://www.rfc-editor.org/rfc/rfc7234.html#section-5.5.7. In #79107 we mistakenly began logging warning-level
messages with the 300 code, which is not valid in the RFC.