[8.x] Downgrade transport.enable_stack_protection deprecation to a warning#124788
Merged
arteam merged 1 commit intoelastic:8.xfrom Mar 14, 2025
Merged
Conversation
…warning This setting is not getting removed in ES 9.0, so its usage should not generate a critical deprecation warning. `TransportServiceLifecycleTests` already uses `assertWarnings` instead of `assertCriticalWarnings` and we don't distinguish between warning levels in assertions (See elastic#80304) See elastic#109236 See ES-11224
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
nicktindall
approved these changes
Mar 13, 2025
Contributor
nicktindall
left a comment
There was a problem hiding this comment.
LGTM. I wonder if we should remove assertCriticalWarnings and just migrate to using assertWarnings across the board (in a separate PR), it's a bit confusing how that passes (I had to stare at it for a bit until I realised the equals method for DeprecationWarning doesn't include the level).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This setting is not getting removed in ES 9.0, so its usage should not generate a critical deprecation warning.
TransportServiceLifecycleTestsalready usesassertWarningsinstead ofassertCriticalWarningsand we don't distinguish between warning levels in assertions (See #80304)See #109236
See ES-11224