Deprecation of transient cluster settings#78794
Merged
grcevski merged 38 commits intoelastic:masterfrom Oct 15, 2021
Merged
Conversation
added 11 commits
October 1, 2021 11:18
We are deprecating transient settings, therefore this PR changes uses of transient cluster settings to persistent cluster settings.
Revert back tests that test specifically for the transient settings functionality.
added 15 commits
October 6, 2021 17:22
…transient_cluster_settings
…transient_cluster_settings
grcevski
commented
Oct 13, 2021
| import org.elasticsearch.cluster.metadata.AliasMetadata; | ||
| import org.elasticsearch.cluster.metadata.ComponentTemplate; | ||
| import org.elasticsearch.cluster.metadata.Template; | ||
| import org.elasticsearch.cluster.routing.allocation.decider.EnableAllocationDecider; |
Contributor
Author
There was a problem hiding this comment.
The changes in this file are actually a revert from my previous PR (#78562), since we are keeping the docs for transient settings this should also have the transient settings. I'm actually not sure how did the docs CI job pass for #78562, it should've failed for put_settings.asciidoc after I reverted those updates. I noticed it in my 7.x back port.
Collaborator
|
Pinging @elastic/clients-team (Team:Clients) |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/part-1 |
rjernst
approved these changes
Oct 14, 2021
Member
rjernst
left a comment
There was a problem hiding this comment.
LGTM, just a minor comment about the deprecation message itself.
| public class RestClusterUpdateSettingsAction extends BaseRestHandler { | ||
| private static final DeprecationLogger deprecationLogger = DeprecationLogger.getLogger(RestClusterUpdateSettingsAction.class); | ||
| static final String TRANSIENT_SETTINGS_DEPRECATION_MESSAGE = "[transientSettings removal]" + | ||
| " Updating cluster settings through transientSettings is deprecated. Prefer using persistent settings instead."; |
Member
There was a problem hiding this comment.
should it be transient settings rather than camelCase?
Also, instead of Prefer using... I would say Use ...
Contributor
Author
There was a problem hiding this comment.
I'll change it, thanks!
| return new DeprecationIssue(DeprecationIssue.Level.WARNING, | ||
| "Transient cluster settings are in the process of being removed.", | ||
| "https://ela.st/es-deprecation-7-transient-cluster-settings", | ||
| "Prefer using persistent settings to define your cluster settings instead.", |
Member
There was a problem hiding this comment.
Same comment, I think we should use active language, Use ...
Contributor
Author
|
@elasticmachine update branch |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
grcevski
added a commit
that referenced
this pull request
Oct 15, 2021
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Oct 18, 2021
* upstream/master: (109 commits) Migrate custom role providers to licensed feature (elastic#79127) Remove stale AwaitsFix in InternalEngineTests (elastic#79323) Fix errors in RefreshListenersTests (elastic#79324) Reeable BwC Tests after elastic#79318 (elastic#79320) Mute BwC Tests for elastic#79318 (elastic#79319) Reenable BwC Tests after elastic#79308 (elastic#79313) Disable BwC Tests for elastic#79308 (elastic#79310) Adjust BWC for node-level field cap requests (elastic#79301) Allow total memory to be overridden (elastic#78750) Fix SnapshotBasedIndexRecoveryIT#testRecoveryIsCancelledAfterDeletingTheIndex (elastic#79269) Disable BWC tests Mute GeoIpDownloaderCliIT.testStartWithNoDatabases (elastic#79299) Add alias support to fleet search API (elastic#79285) Create a coordinating node level reader for tsdb (elastic#79197) Route documents to the correct shards in tsdb (elastic#77731) Inject migrate action regardless of allocate action (elastic#79090) Migrate to data tiers should always ensure a TIER_PREFERENCE is set (elastic#79100) Skip building of BWC distributions when building release artifacts (elastic#79180) Default ENFORCE_DEFAULT_TIER_PREFERENCE to true (elastic#79275) Deprecation of transient cluster settings (elastic#78794) ... # Conflicts: # server/src/main/java/org/elasticsearch/index/IndexMode.java # server/src/test/java/org/elasticsearch/index/TimeSeriesModeTests.java
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Oct 18, 2021
* upstream/master: (521 commits) Migrate custom role providers to licensed feature (elastic#79127) Remove stale AwaitsFix in InternalEngineTests (elastic#79323) Fix errors in RefreshListenersTests (elastic#79324) Reeable BwC Tests after elastic#79318 (elastic#79320) Mute BwC Tests for elastic#79318 (elastic#79319) Reenable BwC Tests after elastic#79308 (elastic#79313) Disable BwC Tests for elastic#79308 (elastic#79310) Adjust BWC for node-level field cap requests (elastic#79301) Allow total memory to be overridden (elastic#78750) Fix SnapshotBasedIndexRecoveryIT#testRecoveryIsCancelledAfterDeletingTheIndex (elastic#79269) Disable BWC tests Mute GeoIpDownloaderCliIT.testStartWithNoDatabases (elastic#79299) Add alias support to fleet search API (elastic#79285) Create a coordinating node level reader for tsdb (elastic#79197) Route documents to the correct shards in tsdb (elastic#77731) Inject migrate action regardless of allocate action (elastic#79090) Migrate to data tiers should always ensure a TIER_PREFERENCE is set (elastic#79100) Skip building of BWC distributions when building release artifacts (elastic#79180) Default ENFORCE_DEFAULT_TIER_PREFERENCE to true (elastic#79275) Deprecation of transient cluster settings (elastic#78794) ... # Conflicts: # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/tsdb/10_settings.yml # server/src/main/java/org/elasticsearch/common/settings/IndexScopedSettings.java # server/src/main/java/org/elasticsearch/common/settings/Setting.java # server/src/main/java/org/elasticsearch/index/IndexMode.java # server/src/test/java/org/elasticsearch/index/TimeSeriesModeTests.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are deprecating transient cluster settings in 7.16.0, so this PR adds the final deprecation warning.
I made few docs changes here to discourage use of transient settings where we don't need to.
After the deprecation is ported in 7.x, I'll submit a follow-up docs only PR for 7.x to add the 7.16
deprecation notice and make the deprecation link real.
Relates to #49540