Ensuring that the ShrinkAction does not hang if total shards per node is too low#76732
Merged
masseyke merged 4 commits intoelastic:masterfrom Aug 20, 2021
Merged
Conversation
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
Member
Author
|
This is related to this PR: #76134 |
dakrone
approved these changes
Aug 19, 2021
Member
dakrone
left a comment
There was a problem hiding this comment.
Generally LGTM, I left one minor comment, thanks for fixing this!
| Settings settings = Settings.builder() | ||
| .put(IndexMetadata.INDEX_ROUTING_REQUIRE_GROUP_SETTING.getKey() + "_id", nodeId.get()).build(); | ||
| .put(IndexMetadata.INDEX_ROUTING_REQUIRE_GROUP_SETTING.getKey() + "_id", nodeId.get()) | ||
| .put(ShardsLimitAllocationDecider.INDEX_TOTAL_SHARDS_PER_NODE_SETTING.getKey(), -1).build(); |
Member
There was a problem hiding this comment.
I think rather than setting this explicitly to -1, we might be better if we did:
Suggested change
| .put(ShardsLimitAllocationDecider.INDEX_TOTAL_SHARDS_PER_NODE_SETTING.getKey(), -1).build(); | |
| .putNull(ShardsLimitAllocationDecider.INDEX_TOTAL_SHARDS_PER_NODE_SETTING.getKey()).build(); |
Since the default value is -1 (rather than setting it to that explicitly)
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Aug 20, 2021
… is too low (elastic#76732) We added configuration to AllocateAction to set the total shards per node property on the index. This makes it possible that a user could set this to a value lower than the total number of shards in the index that is about to be shrunk, meaning that all of the shards could not be moved to a single node in the ShrinkAction. This commit unsets the total shards per node property so that we fall back to the default value (-1, unlimited) in the ShrinkAction to avoid this. Relates to elastic#44070
masseyke
added a commit
that referenced
this pull request
Aug 20, 2021
… is too low (#76732) (#76780) This is a backport of #76732. We added configuration to AllocateAction to set the total shards per node property on the index. This makes it possible that a user could set this to a value lower than the total number of shards in the index that is about to be shrunk, meaning that all of the shards could not be moved to a single node in the ShrinkAction. This commit unsets the total shards per node property so that we fall back to the default value (-1, unlimited) in the ShrinkAction to avoid this. Relates to #44070
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added configuration to AllocateAction to set the total shards per node property on the index. This makes it possible that a user could set this to a value lower than the total number of shards in the index that is about to be shrunk, meaning that all of the shards could not be moved to a single node in the ShrinkAction. This commit sets the total shards per node property to -1 (unlimited) in the ShrinkAction to avoid this.
Relates to #44070