Allow for setting the total shards per node in the Allocate ILM action#76134
Conversation
|
Pinging @elastic/es-core-features (Team:Core/Features) |
|
@elasticmachine update branch |
dakrone
left a comment
There was a problem hiding this comment.
Thanks for working on this Keith, I left a few comments
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/AllocateAction.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/AllocateAction.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/AllocateAction.java
Show resolved
Hide resolved
|
@elasticmachine update branch |
|
Note that one catch on this PR is that if you set the total_number_of_shards in your allocate action to less than the number of shards in the current index, then shrinking will just hang (because the step in shrinking that copies all shards to one node will be blocked). This was mentioned in #44070 but hasn't been addressed in this PR. |
dakrone
left a comment
There was a problem hiding this comment.
LGTM, though I think in the interest of user friendliness this should go into 8.0 and 7.16+ instead of 7.15, so that we have time to work on the changes to the shrink action that makes it not possible to wedge itself (which should be done in a followup PR I think)
|
Thx! def +++++ on the backport to 7.1x |
This PR fixes the above problem: #76732 |
elastic#76134) This adds a new optional field to the allocate ILM action called "total_shards_per_node". If present, the value of this field is set as the value of "index.routing.allocation.total_shards_per_node" before the allocation takes place. Relates to elastic#44070
#76775) Allow for setting the total shards per node in the Allocate ILM action (#76134) This is a backport of #76134. It adds a new optional field to the allocate ILM action called "total_shards_per_node". If present, the value of this field is set as the value of "index.routing.allocation.total_shards_per_node" before the allocation takes place. Relates to #44070
This adds a new optional field to the allocate ILM action called "total_shards_per_node". If present, the value of this field
is set as the value of "index.routing.allocation.total_shards_per_node" before the allocation takes place.