Align XCombinedFieldQuery with latest Lucene changes#75483
Merged
jtibshirani merged 1 commit intoelastic:masterfrom Jul 20, 2021
Merged
Align XCombinedFieldQuery with latest Lucene changes#75483jtibshirani merged 1 commit intoelastic:masterfrom
jtibshirani merged 1 commit intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
cbuescher
approved these changes
Jul 20, 2021
Member
cbuescher
left a comment
There was a problem hiding this comment.
LGTM, I assume this mostly carries over changes from apache/lucene#185 that were made after we carried over the copies, at least that's what a quick crosscheck looked like to me.
Contributor
Author
|
Thanks for the review -- yep I just copied over the changes that were made later. |
jtibshirani
added a commit
that referenced
this pull request
Jul 20, 2021
In #74678 we released an early fix for a Lucene bug around `combined_fields` queries with missing fields. This PR brings our fix up-to-date with what was actually committed to Lucene.
jtibshirani
added a commit
that referenced
this pull request
Jul 20, 2021
In #74678 we released an early fix for a Lucene bug around `combined_fields` queries with missing fields. This PR brings our fix up-to-date with what was actually committed to Lucene.
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 30, 2021
In elastic#74678 we released an early fix for a Lucene bug around `combined_fields` queries with missing fields. This PR brings our fix up-to-date with what was actually committed to Lucene.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #74678 we released an early fix for a Lucene bug around
combined_fieldsqueries with missing fields. This PR brings our fix up-to-date with what was
actually committed to Lucene.