Fix CombinedFieldQuery (Lucene 9999)#74678
Merged
cbuescher merged 3 commits intoelastic:masterfrom Jun 29, 2021
Merged
Conversation
This commit moves a fix for a bug in MultiNormsLeafSimScorer in Lucene that fixes an error in the new CombinedFieldQuery for missing values. Its based on a PR for LUCENE-9999 (apache/lucene#185). This is a temporary copy of the affected query and its updated dependencies that should be removed again once we are able to use the original fix from Lucene. Relastes to apache/lucene#185
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Jun 29, 2021
This commit moves a fix for a bug in MultiNormsLeafSimScorer in Lucene that fixes an error in the new CombinedFieldQuery for missing values. Its based on a PR for LUCENE-9999 (apache/lucene#185). This is a temporary copy of the affected query and its updated dependencies that should be removed again once we are able to use the original fix from Lucene. Relastes to apache/lucene#185
cbuescher
pushed a commit
that referenced
this pull request
Jun 30, 2021
This commit moves a fix for a bug in MultiNormsLeafSimScorer in Lucene that fixes an error in the new CombinedFieldQuery for missing values. Its based on a PR for LUCENE-9999 (apache/lucene#185). This is a temporary copy of the affected query and its updated dependencies that should be removed again once we are able to use the original fix from Lucene. Relates to apache/lucene#185
jtibshirani
added a commit
that referenced
this pull request
Jul 20, 2021
In #74678 we released an early fix for a Lucene bug around `combined_fields` queries with missing fields. This PR brings our fix up-to-date with what was actually committed to Lucene.
jtibshirani
added a commit
that referenced
this pull request
Jul 20, 2021
In #74678 we released an early fix for a Lucene bug around `combined_fields` queries with missing fields. This PR brings our fix up-to-date with what was actually committed to Lucene.
jtibshirani
added a commit
that referenced
this pull request
Jul 20, 2021
In #74678 we released an early fix for a Lucene bug around `combined_fields` queries with missing fields. This PR brings our fix up-to-date with what was actually committed to Lucene.
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 30, 2021
In elastic#74678 we released an early fix for a Lucene bug around `combined_fields` queries with missing fields. This PR brings our fix up-to-date with what was actually committed to Lucene.
dnhatn
added a commit
that referenced
this pull request
Sep 20, 2021
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Sep 20, 2021
This change removes the XCombinedFieldQuery workaround introduced in elastic#74678 as the fix is integrated into Lucene 8.10. Relates elastic#74678
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit moves a fix for a bug in MultiNormsLeafSimScorer in Lucene that
fixes an error in the new CombinedFieldQuery for missing values. Its based on
a PR for LUCENE-9999 (apache/lucene#185). This is a
temporary copy of the affected query and its updated dependencies that should be
removed again once we are able to use the original fix from Lucene.
Relates to apache/lucene#185