Make DataStreamsSnapshotsIT resilient to failures because of local time.#73516
Merged
martijnvg merged 3 commits intoelastic:masterfrom May 28, 2021
Merged
Conversation
Backing index names contain a date component. Instead of defining what the expected backing index names are before creating the data streams, resolve these expected backing index names after the data streams are created. This way we avoid failures that can occur around midnight (local time), where the expected names are created before midnight and the data streams are created after midnight. Closes elastic#73510
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
andreidan
approved these changes
May 28, 2021
Contributor
andreidan
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this Martijn
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
May 28, 2021
…me. (elastic#73516) Backing index names contain a date component. Instead of defining what the expected backing index names are before creating the data streams, resolve these expected backing index names after the data streams are created. This way we avoid failures that can occur around midnight (local time), where the expected names are created before midnight and the data streams are created after midnight. Closes elastic#73510
limingnihao
added a commit
to limingnihao/elasticsearch
that referenced
this pull request
May 28, 2021
* master: (1643 commits) Make DataStreamsSnapshotsIT resilient to failures because of local time. (elastic#73516) Upgrade netty to 4.1.63 (elastic#73011) [DOCS] Create a new page for dissect content in scripting docs (elastic#73437) Deprecate freeze index API (elastic#72618) [DOCS] Remove 'closed data stream' reference [DOCS] Update alias references (elastic#73427) [DOCS] Create a new page for grok content in scripting docs (elastic#73118) Remove dependency on azure shadowjar since it's no longer required [DOCS] Update backport policy for known issues (elastic#73489) Shadowed dependencies should be hidden from pom dependencies (elastic#73467) Disable transitive dependencies when resolving bwc JDBC driver artifact (elastic#73448) Print full JVM implementation version at start of build (elastic#73439) [DOCS] Update snapshot/restore for data stream aliases (elastic#73438) Upgrade Azure SDK and Jackson (elastic#72833) (elastic#72995) [DOCS] Fix typo (elastic#73337) (elastic#73474) [DOCS] Fix typo (elastic#73444) (elastic#73472) [DOCS] Update alias security for data stream aliases (elastic#73436) Fix Bug with Concurrent Snapshot and Index Delete (elastic#73456) [DOCS] Move common scripting use cases up a level (elastic#73445) Add more validation for data stream aliases. (elastic#73416) ...
martijnvg
added a commit
that referenced
this pull request
May 28, 2021
…me. (#73522) Backport #73516 to 7.x branch. Backing index names contain a date component. Instead of defining what the expected backing index names are before creating the data streams, resolve these expected backing index names after the data streams are created. This way we avoid failures that can occur around midnight (local time), where the expected names are created before midnight and the data streams are created after midnight. Closes #73510
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backing index names contain a date component.
Instead of defining what the expected backing index names are before creating the data streams,
resolve these expected backing index names after the data streams are created.
This way we avoid failures that can occur around midnight (local time), where the expected
names are created before midnight and the data streams are created after midnight.
Closes #73510