Fix Bug with Concurrent Snapshot and Index Delete#73456
Merged
DaveCTurner merged 6 commits intoelastic:masterfrom May 27, 2021
original-brownbear:fix-snapshot-bug
Merged
Fix Bug with Concurrent Snapshot and Index Delete#73456DaveCTurner merged 6 commits intoelastic:masterfrom original-brownbear:fix-snapshot-bug
DaveCTurner merged 6 commits intoelastic:masterfrom
original-brownbear:fix-snapshot-bug
Conversation
Fix state machine bug that fixes the incorrect assumption a finished snapshot delete could only start shard snapshots when in fact it can also move snapshots to a completed state.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
approved these changes
May 27, 2021
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
Suggested a couple of small tidy-ups but LGTM.
.../internalClusterTest/java/org/elasticsearch/snapshots/DedicatedClusterSnapshotRestoreIT.java
Outdated
Show resolved
Hide resolved
.../internalClusterTest/java/org/elasticsearch/snapshots/DedicatedClusterSnapshotRestoreIT.java
Outdated
Show resolved
Hide resolved
.../internalClusterTest/java/org/elasticsearch/snapshots/DedicatedClusterSnapshotRestoreIT.java
Outdated
Show resolved
Hide resolved
tlrx
reviewed
May 27, 2021
| final SnapshotsInProgress.Entry updatedEntry = entry.withShardStates(updatedAssignmentsBuilder.build()); | ||
| snapshotEntries.add(updatedEntry); | ||
| changed = true; | ||
| if (updatedEntry.state().completed()) { |
Member
There was a problem hiding this comment.
sorry if this is a stupid remark but should we do the same thing for the cloning path?
Contributor
Author
There was a problem hiding this comment.
No worries :) The clone path isn't affected by this, the logic there is different and always sets the snapshot overall state correctly. Also, there cannot be a concurrent removal of shards for clones anyway :)
DaveCTurner
pushed a commit
that referenced
this pull request
May 27, 2021
Fixes the incorrect assumption in the snapshot state machine that a finished snapshot delete could only start shard snapshots: in fact it can also move snapshots to a completed state.
DaveCTurner
pushed a commit
that referenced
this pull request
May 27, 2021
Fixes the incorrect assumption in the snapshot state machine that a finished snapshot delete could only start shard snapshots: in fact it can also move snapshots to a completed state.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 27, 2021
Adds docs to the release notes for 7.9-7.12 recording elastic#73456 as a known issue.
Contributor
Author
|
Thanks David!! |
DaveCTurner
added a commit
that referenced
this pull request
May 27, 2021
DaveCTurner
added a commit
that referenced
this pull request
May 27, 2021
DaveCTurner
added a commit
that referenced
this pull request
May 27, 2021
jrodewig
pushed a commit
that referenced
this pull request
May 27, 2021
jrodewig
pushed a commit
that referenced
this pull request
May 27, 2021
jrodewig
pushed a commit
that referenced
this pull request
May 27, 2021
limingnihao
added a commit
to limingnihao/elasticsearch
that referenced
this pull request
May 28, 2021
* master: (1643 commits) Make DataStreamsSnapshotsIT resilient to failures because of local time. (elastic#73516) Upgrade netty to 4.1.63 (elastic#73011) [DOCS] Create a new page for dissect content in scripting docs (elastic#73437) Deprecate freeze index API (elastic#72618) [DOCS] Remove 'closed data stream' reference [DOCS] Update alias references (elastic#73427) [DOCS] Create a new page for grok content in scripting docs (elastic#73118) Remove dependency on azure shadowjar since it's no longer required [DOCS] Update backport policy for known issues (elastic#73489) Shadowed dependencies should be hidden from pom dependencies (elastic#73467) Disable transitive dependencies when resolving bwc JDBC driver artifact (elastic#73448) Print full JVM implementation version at start of build (elastic#73439) [DOCS] Update snapshot/restore for data stream aliases (elastic#73438) Upgrade Azure SDK and Jackson (elastic#72833) (elastic#72995) [DOCS] Fix typo (elastic#73337) (elastic#73474) [DOCS] Fix typo (elastic#73444) (elastic#73472) [DOCS] Update alias security for data stream aliases (elastic#73436) Fix Bug with Concurrent Snapshot and Index Delete (elastic#73456) [DOCS] Move common scripting use cases up a level (elastic#73445) Add more validation for data stream aliases. (elastic#73416) ...
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Nov 11, 2021
The known-issue docs give the impression that an upgrade will restore the lost data in the repository. This isn't the case, so this commit clarifies this in the docs. Relates elastic#73456 Relates elastic#75598 Relates elastic#79221
DaveCTurner
added a commit
that referenced
this pull request
Nov 15, 2021
DaveCTurner
added a commit
that referenced
this pull request
Nov 15, 2021
DaveCTurner
added a commit
that referenced
this pull request
Nov 15, 2021
DaveCTurner
added a commit
that referenced
this pull request
Nov 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix state machine bug that fixes the incorrect assumption a finished snapshot delete
could only start shard snapshots when in fact it can also move snapshots to a
completed state.