Merged
Conversation
Member
Author
|
@elasticmachine update branch |
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
nik9000
approved these changes
May 26, 2021
| can resolve the issue by coercing the unmapped field into the correct type. | ||
|
|
||
| [source,console,id=terms-aggregation-value_type-example] | ||
| -------------------------------------------------- |
Member
There was a problem hiding this comment.
Four - is enough for these. I've been trying to stick to it out of sheer stubbornness.
Member
Author
|
@elasticmachine update branch |
not-napoleon
added a commit
that referenced
this pull request
Jun 7, 2021
Improve the error message when inconsistent mappings cause doc value formatting errors. For example, trying to format a binary encoded IP address as a UTF8 string often fails with something unexpected, like `ArrayIndexOutOfBounds`. This change catches that and wraps it with a message suggesting the user check their mappings. Also gets rid of anonymous instances for doc value formatters, which made it hard to see what format was failing to be applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #72040
When an aggregation gets run across multiple indices with conflicting mappings (e.g. one maps the field being aggregated as an IP address and another maps it as a keyword), the situation can go undetected until the formatting stage. Formatting can then fail with an unhelpful error (e.g.
Array index out of bounds). This PR catches many such errors and wraps them with a clearer error message, which will hopefully steer users towards a resolution.