Remove deprecated ._tier allocation filtering settings#73074
Merged
dakrone merged 6 commits intoelastic:masterfrom May 24, 2021
Merged
Remove deprecated ._tier allocation filtering settings#73074dakrone merged 6 commits intoelastic:masterfrom
dakrone merged 6 commits intoelastic:masterfrom
Conversation
These settings were deprecated in 7.13+ in elastic#72835 and are now removed by this commit. This commit also ensures that the settings are removed from index metadata when the metadata is loaded. The reason for this is that if we allow the settings to remain (because they are not technically "invalid"), then the index will not be able to be allocated, because the `FilterAllocationDecider` will be looking for nodes with the `_tier` attribute.
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
Member
Author
|
@elasticmachine run elasticsearch-ci/part-1 I opened #73208 for the failure |
andreidan
approved these changes
May 24, 2021
Contributor
andreidan
left a comment
There was a problem hiding this comment.
LGTM, thanks for working on this Lee
server/src/main/java/org/elasticsearch/cluster/metadata/IndexMetadataVerifier.java
Outdated
Show resolved
Hide resolved
…etadataVerifier.java Co-authored-by: Andrei Dan <andrei.dan@elastic.co>
Member
Author
|
@elasticmachine update branch |
Member
Author
|
@elasticmachine run elasticsearch-ci/part-1 |
80 tasks
masseyke
added a commit
that referenced
this pull request
Sep 2, 2021
Adding deprecation info API checks for the following properties that were removed in 8.0: cluster.routing.allocation.require._tier cluster.routing.allocation.include._tie; cluster.routing.allocation.exclude._tier index.routing.allocation.require._tier index.routing.allocation.include._tier index.routing.allocation.exclude._tier Relates #73074
jrodewig
added a commit
that referenced
this pull request
Sep 16, 2021
We deprecated the following settings in 7.13 with PR #72835: - `cluster.routing.allocation.include._tier` - `cluster.routing.allocation.exclude._tier` - `cluster.routing.allocation.require._tier` - `index.routing.allocation.include._tier` - `index.routing.allocation.exclude._tier` - `index.routing.allocation.require._tier` However, we didn't add a related item to the 7.13 deprecation docs. This adds the missing item. Relates to #73074.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
We deprecated the following settings in 7.13 with PR #72835: - `cluster.routing.allocation.include._tier` - `cluster.routing.allocation.exclude._tier` - `cluster.routing.allocation.require._tier` - `index.routing.allocation.include._tier` - `index.routing.allocation.exclude._tier` - `index.routing.allocation.require._tier` However, we didn't add a related item to the 7.13 deprecation docs. This adds the missing item. Relates to #73074.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
We deprecated the following settings in 7.13 with PR #72835: - `cluster.routing.allocation.include._tier` - `cluster.routing.allocation.exclude._tier` - `cluster.routing.allocation.require._tier` - `index.routing.allocation.include._tier` - `index.routing.allocation.exclude._tier` - `index.routing.allocation.require._tier` However, we didn't add a related item to the 7.13 deprecation docs. This adds the missing item. Relates to #73074.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
We deprecated the following settings in 7.13 with PR #72835: - `cluster.routing.allocation.include._tier` - `cluster.routing.allocation.exclude._tier` - `cluster.routing.allocation.require._tier` - `index.routing.allocation.include._tier` - `index.routing.allocation.exclude._tier` - `index.routing.allocation.require._tier` However, we didn't add a related item to the 7.13 deprecation docs. This adds the missing item. Relates to #73074.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These settings were deprecated in 7.13+ in #72835 and are now removed by this commit.
This commit also ensures that the settings are removed from index metadata when the metadata is
loaded. The reason for this is that if we allow the settings to remain (because they are not
technically "invalid"), then the index will not be able to be allocated, because the
FilterAllocationDeciderwill be looking for nodes with the_tierattribute.