Deprecate single-tier allocation filtering settings#72835
Merged
dakrone merged 3 commits intoelastic:masterfrom May 11, 2021
Merged
Deprecate single-tier allocation filtering settings#72835dakrone merged 3 commits intoelastic:masterfrom
dakrone merged 3 commits intoelastic:masterfrom
Conversation
`(index|cluster).routing.allocation.(include|exclude|require)._tier` settings are now deprecated in favor of using `index.routing.allocation.include._tier_preference`.
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
Member
Author
|
I will follow this up with a PR to remove these settings on master once this is in. |
henningandersen
approved these changes
May 8, 2021
Contributor
henningandersen
left a comment
There was a problem hiding this comment.
LGTM.
About the 8.0 part, I think we need to keep the settings but ignore them in 8.0 and then remove in 9. Will send you a message through another channel on this.
docs/reference/index-modules/allocation/data_tier_allocation.asciidoc
Outdated
Show resolved
Hide resolved
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
May 11, 2021
* Deprecate single-tier allocation filtering settings `(index|cluster).routing.allocation.(include|exclude|require)._tier` settings are now deprecated in favor of using `index.routing.allocation.include._tier_preference`. * Update deprecation message
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
May 11, 2021
* Deprecate single-tier allocation filtering settings `(index|cluster).routing.allocation.(include|exclude|require)._tier` settings are now deprecated in favor of using `index.routing.allocation.include._tier_preference`. * Update deprecation message
dakrone
added a commit
that referenced
this pull request
May 11, 2021
…72943) * Deprecate single-tier allocation filtering settings `(index|cluster).routing.allocation.(include|exclude|require)._tier` settings are now deprecated in favor of using `index.routing.allocation.include._tier_preference`. * Update deprecation message
dakrone
added a commit
that referenced
this pull request
May 11, 2021
…72942) * Deprecate single-tier allocation filtering settings `(index|cluster).routing.allocation.(include|exclude|require)._tier` settings are now deprecated in favor of using `index.routing.allocation.include._tier_preference`. * Update deprecation message
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
May 13, 2021
These settings were deprecated in 7.13+ in elastic#72835 and are now removed by this commit. This commit also ensures that the settings are removed from index metadata when the metadata is loaded. The reason for this is that if we allow the settings to remain (because they are not technically "invalid"), then the index will not be able to be allocated, because the `FilterAllocationDecider` will be looking for nodes with the `_tier` attribute.
dakrone
added a commit
that referenced
this pull request
May 24, 2021
These settings were deprecated in 7.13+ in #72835 and are now removed by this commit. This commit also ensures that the settings are removed from index metadata when the metadata is loaded. The reason for this is that if we allow the settings to remain (because they are not technically "invalid"), then the index will not be able to be allocated, because the FilterAllocationDecider will be looking for nodes with the _tier attribute.
jrodewig
added a commit
that referenced
this pull request
Sep 16, 2021
We deprecated the following settings in 7.13 with PR #72835: - `cluster.routing.allocation.include._tier` - `cluster.routing.allocation.exclude._tier` - `cluster.routing.allocation.require._tier` - `index.routing.allocation.include._tier` - `index.routing.allocation.exclude._tier` - `index.routing.allocation.require._tier` However, we didn't add a related item to the 7.13 deprecation docs. This adds the missing item. Relates to #73074.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
We deprecated the following settings in 7.13 with PR #72835: - `cluster.routing.allocation.include._tier` - `cluster.routing.allocation.exclude._tier` - `cluster.routing.allocation.require._tier` - `index.routing.allocation.include._tier` - `index.routing.allocation.exclude._tier` - `index.routing.allocation.require._tier` However, we didn't add a related item to the 7.13 deprecation docs. This adds the missing item. Relates to #73074.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
We deprecated the following settings in 7.13 with PR #72835: - `cluster.routing.allocation.include._tier` - `cluster.routing.allocation.exclude._tier` - `cluster.routing.allocation.require._tier` - `index.routing.allocation.include._tier` - `index.routing.allocation.exclude._tier` - `index.routing.allocation.require._tier` However, we didn't add a related item to the 7.13 deprecation docs. This adds the missing item. Relates to #73074.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
We deprecated the following settings in 7.13 with PR #72835: - `cluster.routing.allocation.include._tier` - `cluster.routing.allocation.exclude._tier` - `cluster.routing.allocation.require._tier` - `index.routing.allocation.include._tier` - `index.routing.allocation.exclude._tier` - `index.routing.allocation.require._tier` However, we didn't add a related item to the 7.13 deprecation docs. This adds the missing item. Relates to #73074.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(index|cluster).routing.allocation.(include|exclude|require)._tiersettings are now deprecated infavor of using
index.routing.allocation.include._tier_preference.