Skip to content

Make NodeEnvironment.availableShardPaths singular#72441

Merged
rjernst merged 1 commit intoelastic:masterfrom
rjernst:mdp18
Apr 29, 2021
Merged

Make NodeEnvironment.availableShardPaths singular#72441
rjernst merged 1 commit intoelastic:masterfrom
rjernst:mdp18

Conversation

@rjernst
Copy link
Copy Markdown
Member

@rjernst rjernst commented Apr 29, 2021

This commit renames the availableShardPaths method to be singular and
return a single Path instead of an array.

relates #71205

This commit renames the availableShardPaths method to be singular and
return a single Path instead of an array.

relates elastic#71205
@rjernst rjernst added :Core/Infra/Core Core issues without another label >refactoring v8.0.0 labels Apr 29, 2021
@rjernst rjernst requested a review from DaveCTurner April 29, 2021 06:02
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Apr 29, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Copy Markdown
Member

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjernst rjernst merged commit faede0a into elastic:master Apr 29, 2021
@rjernst rjernst deleted the mdp18 branch April 29, 2021 18:58
@rjernst rjernst mentioned this pull request Sep 30, 2021
17 tasks
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Oct 12, 2021
)"

This reverts commit faede0a.

This revert was conflict free.

relates elastic#78525
relates elastic#71205
rjernst added a commit that referenced this pull request Oct 12, 2021
…78985)

This reverts commit faede0a.

This revert was conflict free.

relates #78525
relates #71205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Core Core issues without another label >refactoring Team:Core/Infra Meta label for core/infra team v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants