Skip to content

Revert "Make NodeEnvironment.availableShardPaths singular (#72441)"#78985

Merged
rjernst merged 3 commits intoelastic:masterfrom
rjernst:mdp/revert12
Oct 12, 2021
Merged

Revert "Make NodeEnvironment.availableShardPaths singular (#72441)"#78985
rjernst merged 3 commits intoelastic:masterfrom
rjernst:mdp/revert12

Conversation

@rjernst
Copy link
Copy Markdown
Member

@rjernst rjernst commented Oct 12, 2021

This reverts commit faede0a.

This revert was conflict free.

relates #78525
relates #71205

)"

This reverts commit faede0a.

This revert was conflict free.

relates elastic#78525
relates elastic#71205
@rjernst rjernst added >non-issue :Core/Infra/Core Core issues without another label v8.0.0 labels Oct 12, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Oct 12, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@rjernst rjernst mentioned this pull request Oct 12, 2021
17 tasks
Copy link
Copy Markdown
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

// lets see if it's path is available (return false if the shard doesn't exist)
// we don't need to delete anything that is not there
return Files.exists(nodeEnv.availableShardPath(shardId)) ?
return FileSystemUtils.exists(nodeEnv.availableShardPaths(shardId)) ?
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like reverting 56e525f is missing.

@rjernst
Copy link
Copy Markdown
Member Author

rjernst commented Oct 12, 2021

@elasticmachine run elasticsearch-ci/part-2

@rjernst rjernst merged commit 2cb444c into elastic:master Oct 12, 2021
@rjernst rjernst deleted the mdp/revert12 branch October 12, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Core Core issues without another label >non-issue Team:Core/Infra Meta label for core/infra team v8.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants