Skip to content

Fix failure in TransformPivotRestSpecialCasesIT::testIndexTemplateMappingClash#71778

Merged
danhermann merged 3 commits intoelastic:masterfrom
danhermann:index_template_test_fix
Apr 19, 2021
Merged

Fix failure in TransformPivotRestSpecialCasesIT::testIndexTemplateMappingClash#71778
danhermann merged 3 commits intoelastic:masterfrom
danhermann:index_template_test_fix

Conversation

@danhermann
Copy link
Copy Markdown
Contributor

@danhermann danhermann commented Apr 16, 2021 •
edited
Loading

Fixes a test that wasn't caught in the PR build for #71309

Fixes #71792

@danhermann danhermann added >test Issues or PRs that are addressing/adding tests :Data Management/Indices APIs DO NOT USE. Use ":Distributed/Indices APIs" or ":StorageEngine/Templates" instead. v8.0.0 v7.13.0 labels Apr 16, 2021
@elasticmachine elasticmachine added the Team:Data Management (obsolete) DO NOT USE. This team no longer exists. label Apr 16, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Apr 16, 2021

Pinging @elastic/es-core-features (Team:Core/Features)

@danhermann
Copy link
Copy Markdown
Contributor Author

danhermann commented Apr 16, 2021

@elasticmachine run elasticsearch-ci/bwc

@henningandersen henningandersen mentioned this pull request Apr 16, 2021
Merged
henningandersen
henningandersen approved these changes Apr 17, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This was referenced Apr 18, 2021
Closed
Merged
Merged
@henningandersen
Copy link
Copy Markdown
Contributor

henningandersen commented Apr 19, 2021

Muted in 7.x and master (#71810).

hendrikmuhs
hendrikmuhs approved these changes Apr 19, 2021
View reviewed changes
Copy link
Copy Markdown

@hendrikmuhs hendrikmuhs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But please rebase and unmute 567c56e with the merge.

@danhermann
Copy link
Copy Markdown
Contributor Author

danhermann commented Apr 19, 2021

@elasticmachine update branch

@danhermann danhermann merged commit c831d88 into elastic:master Apr 19, 2021
@danhermann danhermann deleted the index_template_test_fix branch April 19, 2021 12:34
@danhermann
Copy link
Copy Markdown
Contributor Author

danhermann commented Apr 19, 2021

Thanks, @henningandersen and @hendrikmuhs.

danhermann added a commit to danhermann/elasticsearch that referenced this pull request Apr 19, 2021
@danhermann
Fix failure in TransformPivotRestSpecialCasesIT::testIndexTemplateMap…
a602846 
…pingClash (elastic#71778)
@danhermann danhermann mentioned this pull request Apr 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henningandersen henningandersen henningandersen approved these changes

+1 more reviewer

@hendrikmuhs hendrikmuhs hendrikmuhs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Data Management/Indices APIs DO NOT USE. Use ":Distributed/Indices APIs" or ":StorageEngine/Templates" instead. Team:Data Management (obsolete) DO NOT USE. This team no longer exists. >test Issues or PRs that are addressing/adding tests v7.13.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] Reproducible Failure in org.elasticsearch.xpack.transform.integration.TransformPivotRestSpecialCasesIT.testIndexTemplateMappingClash

5 participants

@danhermann @elasticmachine @henningandersen @hendrikmuhs @jakelandis