Deprecate legacy index template API endpoints#71309
Deprecate legacy index template API endpoints#71309danhermann merged 20 commits intoelastic:masterfrom
Conversation
|
@elasticmachine update branch |
|
Pinging @elastic/es-core-features (Team:Core/Features) |
dakrone
left a comment
There was a problem hiding this comment.
LGTM, thanks for doing this @danhermann, I left two comment but they're pretty minor
|
|
||
| public static final String DEPRECATION_WARNING = "Legacy index templates are deprecated and will be removed completely in a " + | ||
| "future version. Please use composable templates instead."; | ||
| private static final RestApiVersion DEPRECATION_VERSION = RestApiVersion.V_8; |
There was a problem hiding this comment.
Is this going to change to V_7 for the backport? Should this be V_7 right now so that the REST API compat. header still gets the deprecation (given that it's being deprecated in 7.x also)?
There was a problem hiding this comment.
Changing to V_7 (on the 7.x backport) is almost certainly the correct thing to do (in this case). The semantics of that, then, would be that here on master the legacy index templates are "merely deprecated" and separately also that on 7.x they are also "merely deprecated".
| } | ||
| } | ||
|
|
||
| for (Iterator<String> warnings = unexpected.iterator(); warnings.hasNext();) { |
There was a problem hiding this comment.
Can you add a comment for this block about its purpose?
|
@elasticmachine update branch |
|
expected head sha didn’t match current head ref. |
|
@elasticmachine update branch |
|
Thanks, @dakrone! |
Closes #71307