Skip to content

Remove usage of .watches system index in full cluster restart.#65884

Merged
martijnvg merged 3 commits intoelastic:masterfrom
martijnvg:remove_last_direct_.watch_access
Dec 7, 2020
Merged

Remove usage of .watches system index in full cluster restart.#65884
martijnvg merged 3 commits intoelastic:masterfrom
martijnvg:remove_last_direct_.watch_access

Conversation

@martijnvg
Copy link
Copy Markdown
Member

Make use for the cluster state api to check the index.format setting
of the .watches index instead of querying the index settings api.

This removes the last direct usage of .watches index mentioned in #62501.

Make use for the cluster state api to check the index.format setting
of the .watches index instead of querying the index settings api.

This removes the last direct usage of .watches index mentioned in elastic#62501.
@martijnvg martijnvg added >test Issues or PRs that are addressing/adding tests :Distributed/Watcher v8.0.0 v7.11.0 labels Dec 4, 2020
@martijnvg martijnvg requested a review from jakelandis December 4, 2020 13:51
@elasticmachine elasticmachine added the Team:Data Management (obsolete) DO NOT USE. This team no longer exists. label Dec 4, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

@martijnvg
Copy link
Copy Markdown
Member Author

@elasticmachine run elasticsearch-ci/2

}
}
// Verify .watches index format:
var getClusterStateResponse = entityAsMap(client().performRequest(new Request("GET", "/_cluster/state")));
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: GET /_cluster/state/metadata/.watches would be tiny bit more efficient.

Copy link
Copy Markdown
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martijnvg martijnvg merged commit f09e728 into elastic:master Dec 7, 2020
martijnvg added a commit to martijnvg/elasticsearch that referenced this pull request Dec 7, 2020
Backport elastic#65884 to 7.x branch.

Make use for the cluster state api to check the index.format setting
of the .watches index instead of querying the index settings api.

This removes the last direct usage of .watches index mentioned in elastic#62501.
martijnvg added a commit that referenced this pull request Dec 7, 2020
Backport #65884 to 7.x branch.

Make use for the cluster state api to check the index.format setting
of the .watches index instead of querying the index settings api.

This removes the last direct usage of .watches index mentioned in #62501.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Watcher Team:Data Management (obsolete) DO NOT USE. This team no longer exists. >test Issues or PRs that are addressing/adding tests v7.11.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants