-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Stop accessing System Indices directly in REST tests #62501
Copy link
Copy link
Open
Labels
:Distributed/Task ManagementIssues for anything around the Tasks API - both persistent and node level.Issues for anything around the Tasks API - both persistent and node level.:Security/SecuritySecurity issues without another labelSecurity issues without another label:mlMachine learningMachine learning:ml/TransformTransformTransform>testIssues or PRs that are addressing/adding testsIssues or PRs that are addressing/adding testsMetaTeam:DistributedMeta label for distributed team.Meta label for distributed team.Team:MLMeta label for the ML teamMeta label for the ML teamTeam:SecurityMeta label for security teamMeta label for security team
Metadata
Metadata
Assignees
Labels
:Distributed/Task ManagementIssues for anything around the Tasks API - both persistent and node level.Issues for anything around the Tasks API - both persistent and node level.:Security/SecuritySecurity issues without another labelSecurity issues without another label:mlMachine learningMachine learning:ml/TransformTransformTransform>testIssues or PRs that are addressing/adding testsIssues or PRs that are addressing/adding testsMetaTeam:DistributedMeta label for distributed team.Meta label for distributed team.Team:MLMeta label for the ML teamMeta label for the ML teamTeam:SecurityMeta label for security teamMeta label for security team
Type
Fields
Give feedbackNo fields configured for issues without a type.
As part of formalizing System Indices in Elasticsearch (#50251), we will be restricting access to System Indices via the REST interface, except by means of purpose-built APIs. For example, accessing
.watchesdirectly will not be allowed - all interaction with the.watchesindex via the REST API should use the purpose-built Watcher APIs.If it is necessary to access System Indices via the REST API today, an API should be added to fulfill that need rather than using generic APIs to do so.
There are a number of places in our REST tests which access System Indices directly. These tests will be modified by #60945 to avoid failures by consuming the deprecation warning as necessary, but that is not a long-term solution. The tests below should be evaluated to determine if there is a necessary API that is currently missing, and if so, add that API and convert the test to use it. If not, we should determine an alternate method for testing the functionality which does not directly access System Indices via the REST API.
Tests/test-related methods which currently access System Indices directly via the REST API:
Test Framework
ESRestTestCase.wipeAllIndices- @williamrandolphTasks
delete_by_query/80_slices.yml - Multiple slices with wait_for_completion=falsedelete_by_query/80_slices.yml - Multiple slices with rethrottlereindex/80_slices.yml - Multiple slices with wait_for_completion=falsereindex/80_slices.yml - Multiple slices with rethrottleupdate_by_query/80_slices.yml - Multiple slices with wait_for_completion=falseupdate_by_query/80_slices.yml - Multiple slices with rethrottlerolling_upgrade..upgraded_cluster/10_basic.yml - Find a task result record from the old clusterTransforms
TransformUsageIT.testUsageTransformConfigurationIndexIT.testDeleteConfigurationLeftOverTranformInternalIndexIT.testUpdateDeletesOldTransformConfigTransformRestTestCase.wipeTransformsTranformRobustnessIT.beEvilAndDeleteTheTransformIndexrolling-upgrade..upgraded_cluster/80_transform_jobs_crud.yml - Test index mappings for latest internal index and audit indexML
MlMappingsUpgradeIT.assertUpgradedConfigMappingsIndexMappingTemplateAsserter.assertMlMappingsMatchTemplatesInferenceIngestIT.cleanUpDataml/calendar_crud.yml - Test delete calendar deletes eventsml/custom_all_field.yml - Test wildcard job idml/filter_crud.yml - setup([ML] Remove direct access to system index from filter_crud REST test #63111)ml/filter_crud.yml - Test get all filter given index exists but no mapping for filter_id([ML] Remove direct access to system index from filter_crud REST test #63111)ml/inference_stats_crud.yml - setupml/inference_crud.yml - setupml/index_layout.yml - Test force close does not create stateml/index_layout.yml - Test CRUD on two jobs in shared indexWatcher
WatcherRestTestCase.stopWatcherRemove more usages of .watches system index. #65835WatcherYamlSuiteTestCase.stopWatcherRemove more usages of .watches system index. #65835MonitoringWithWatcherIT.cleanExportersRemove more usages of .watches system index. #65835MonitoringWithWatcherIT.assertTotalWatchCountAdd query watches api to retrieve multiple watches. #64582FullClusterRestartIT.testWatcherRemove usage of .watches system index in full cluster restart. #65884watcher/activate_watch/10_basic.yml - Test activate watch apiUse watcher get api instead of .watches index. #64199watcher/ack_watch/10_basic.yml - Test ack watch apiUse watcher get api instead of .watches index. #64199watcher/delete_watch/10_basic.yml - Test delete watch apiUse watcher get api instead of .watches index. #64199watcher/get_watch/10_basic.yml - Test get watch apiUse watcher get api instead of .watches index. #64199watcher/put_watch/80_put_get_watch_with_passwords.yml - Test putting a watch with a redacted password with old seq no returns an errorUse watcher get api instead of .watches index. #64199managing_watches.asciidocRemove more usages of .watches system index. #65835Security
FullClusterRestartIT.testSecurityNativeRealmusers/10_basic.yml - Test put user with password hash