[ML] Remove direct access to system index from filter_crud REST test#63111
Merged
dimitris-athanasiou merged 1 commit intoelastic:masterfrom Oct 1, 2020
Conversation
This test accesses system indices for 2 reasons. First, it creates a filter that has a different type. This was done to assert that filter is not returned from the APIs. However, now that access to the `.ml-meta` index is restricted, it is not really a concern. Second, it creates a `.ml-meta` index without mappings to test the get API does not fail due to lack of mappings on a sorted field, namely the `filter_id`. Once again, this test is less useful once system indices have restricted access. Relates elastic#62501
Collaborator
|
Pinging @elastic/ml-core (:ml) |
38 tasks
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Oct 1, 2020
…test (elastic#63111) This test accesses system indices for 2 reasons. First, it creates a filter that has a different type. This was done to assert that filter is not returned from the APIs. However, now that access to the `.ml-meta` index is restricted, it is not really a concern. Second, it creates a `.ml-meta` index without mappings to test the get API does not fail due to lack of mappings on a sorted field, namely the `filter_id`. Once again, this test is less useful once system indices have restricted access. Relates elastic#62501 Backport of elastic#63111
dimitris-athanasiou
added a commit
that referenced
this pull request
Oct 1, 2020
…test (#63111) (#63115) This test accesses system indices for 2 reasons. First, it creates a filter that has a different type. This was done to assert that filter is not returned from the APIs. However, now that access to the `.ml-meta` index is restricted, it is not really a concern. Second, it creates a `.ml-meta` index without mappings to test the get API does not fail due to lack of mappings on a sorted field, namely the `filter_id`. Once again, this test is less useful once system indices have restricted access. Relates #62501 Backport of #63111
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test accesses system indices for 2 reasons.
First, it creates a filter that has a different type. This was done
to assert that filter is not returned from the APIs. However,
now that access to the
.ml-metaindex is restricted,it is not really a concern.
Second, it creates a
.ml-metaindex without mappings to testthe get API does not fail due to lack of mappings on a sorted field,
namely the
filter_id. Once again, this test is less useful oncesystem indices have restricted access.
Relates #62501