Make legacy template noop updates not change cluster state#64493
Merged
dakrone merged 2 commits intoelastic:masterfrom Nov 2, 2020
Merged
Make legacy template noop updates not change cluster state#64493dakrone merged 2 commits intoelastic:masterfrom
dakrone merged 2 commits intoelastic:masterfrom
Conversation
When a legacy template does not change, there is no need to create and publish a new cluster state, rather the update should be a noop. Relates to elastic#57851 Resolves elastic#57662
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
andreidan
approved these changes
Nov 2, 2020
Contributor
andreidan
left a comment
There was a problem hiding this comment.
Thanks for fixing this Lee.
LGTM
| } | ||
| } | ||
|
|
||
| @AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/pull/57393") |
Contributor
There was a problem hiding this comment.
This seems to be related to composable templates, the mentioned PR was abandoned though. Is this really fixed? Or was this muted by accident initially?
Member
Author
There was a problem hiding this comment.
It was fixed in the past with Julie's mappings merging, the test was just never unmuted (it's fixed now though)
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Nov 2, 2020
…4493) When a legacy template does not change, there is no need to create and publish a new cluster state, rather the update should be a noop. Relates to elastic#57851 Resolves elastic#57662
Leaf-Lin
added a commit
to elastic/apm-server
that referenced
this pull request
Nov 27, 2020
Similar to elastic/beats#22357, setup.template.overwrite could potentially overload Elasticsearch with too many update requests. On Elasticsearch side, it will be addressed in newer versions by introducing no-op updates which will be available from 7.11+ elastic/elasticsearch#64493 See also elastic/elasticsearch#57662 Thought having some warnings in the APM setting here should prevent users unwittingly leave template auto-creation on across large number of APM.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a legacy template does not change, there is no need to create and publish a new cluster state,
rather the update should be a noop.
Relates to #57851
Resolves #57662