Make noop template updates be cluster state noops#57851
Merged
dakrone merged 2 commits intoelastic:masterfrom Jun 9, 2020
Merged
Make noop template updates be cluster state noops#57851dakrone merged 2 commits intoelastic:masterfrom
dakrone merged 2 commits intoelastic:masterfrom
Conversation
When updating an existing component or composable template that is identical to the existing template, we now skip doing a cluster state update. Resolves elastic#57662
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
andreidan
approved these changes
Jun 9, 2020
Contributor
andreidan
left a comment
There was a problem hiding this comment.
LGTM nice optimisation
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Jun 9, 2020
When updating an existing component or composable template that is identical to the existing template, we now skip doing a cluster state update. Resolves elastic#57662
dakrone
added a commit
that referenced
this pull request
Jun 9, 2020
Contributor
|
Maybe we should backport this to 7.8 given the relation to SDH cases. |
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Jun 29, 2020
Backports the following commits to 7.8:
Make noop template updates be cluster state noops (elastic#57851)
dakrone
added a commit
that referenced
this pull request
Jun 29, 2020
|
It's our understanding this will help out our problem, but Elastic Cloud support seems to think it won't. If our filebeat agents are all set to automatically publish the template, won't this significantly reduce the cluster workload since it won't be trying to update the cluster state after each agent attempts to push a template that isn't changing? |
Member
Author
|
@jhughes-mc it will help with the workload, however, this work only applies to composable and component templates, not legacy templates, so I couldn't say for sure whether this will help you, it would depend on which templates were being used. |
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Nov 2, 2020
When a legacy template does not change, there is no need to create and publish a new cluster state, rather the update should be a noop. Relates to elastic#57851 Resolves elastic#57662
dakrone
added a commit
that referenced
this pull request
Nov 2, 2020
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Nov 2, 2020
…4493) When a legacy template does not change, there is no need to create and publish a new cluster state, rather the update should be a noop. Relates to elastic#57851 Resolves elastic#57662
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When updating an existing component or composable template that is identical to the existing
template, we now skip doing a cluster state update.
Resolves #57662