Skip to content

Move SLM history back to hidden .slm-history#64210

Merged
probakowski merged 37 commits intoelastic:masterfrom
probakowski:dot-slm-history
Nov 2, 2020
Merged

Move SLM history back to hidden .slm-history#64210
probakowski merged 37 commits intoelastic:masterfrom
probakowski:dot-slm-history

Conversation

@probakowski
Copy link
Copy Markdown
Contributor

@probakowski probakowski commented Oct 27, 2020

This change moves SLM history back to .slm-history pattern (with dot) and makes it hidden as we have hidden data streams now.

@probakowski probakowski requested a review from martijnvg November 2, 2020 12:18
@probakowski probakowski marked this pull request as ready for review November 2, 2020 12:18
@probakowski probakowski added :Data Management/ILM+SLM DO NOT USE. Use ":StorageEngine/ILM" or ":Distributed Coordination/SLM" instead. v7.11.0 v8.0.0 labels Nov 2, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-features (:Core/Features/ILM+SLM)

@elasticmachine elasticmachine added the Team:Data Management (obsolete) DO NOT USE. This team no longer exists. label Nov 2, 2020
Copy link
Copy Markdown
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@probakowski probakowski merged commit 5aa3240 into elastic:master Nov 2, 2020
@probakowski probakowski deleted the dot-slm-history branch November 2, 2020 15:40
probakowski added a commit to probakowski/elasticsearch that referenced this pull request Nov 2, 2020
This change moves SLM history back to .slm-history pattern (with dot) and makes it hidden as we have hidden data streams now.
probakowski added a commit that referenced this pull request Nov 2, 2020
* Move SLM history to data stream (#63038)

This change converts SLM history index to data stream.
Consequence of this is name change as name of data stream can't start with .. New name for SLM history data stream will be slm-history-4 (retaining version in the name).
# Conflicts:
#	x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/slm/history/SnapshotHistoryStore.java
#	x-pack/plugin/ilm/src/internalClusterTest/java/org/elasticsearch/xpack/slm/SLMSnapshotBlockingIntegTests.java

* fix compilation

* Move SLM history back to hidden .slm-history (#64210)

This change moves SLM history back to .slm-history pattern (with dot) and makes it hidden as we have hidden data streams now.

* fix checkstyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/ILM+SLM DO NOT USE. Use ":StorageEngine/ILM" or ":Distributed Coordination/SLM" instead. >refactoring Team:Data Management (obsolete) DO NOT USE. This team no longer exists. v7.11.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants