Move SLM history to data stream#63038
Merged
probakowski merged 5 commits intoelastic:masterfrom Oct 1, 2020
Merged
Conversation
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
dakrone
approved these changes
Sep 30, 2020
Member
dakrone
left a comment
There was a problem hiding this comment.
LGTM, I left one super minor comment, thanks Przemko!
| Metadata metadata = clusterService.state().getMetadata(); | ||
| if (metadata.dataStreams().containsKey(SLM_HISTORY_DATA_STREAM) == false && | ||
| metadata.templatesV2().containsKey(SLM_TEMPLATE_NAME) == false) { | ||
| logger.error(new ParameterizedMessage("failed to index snapshot history item in index [{}]: [{}]", |
Member
There was a problem hiding this comment.
I think this should be a bit more descriptive about why it failed (such as mentioning that the data stream and template were missing) since we don't have an exception in this case
Contributor
Author
There was a problem hiding this comment.
You are right, I reworded error message
probakowski
added a commit
to probakowski/elasticsearch
that referenced
this pull request
Oct 1, 2020
This change converts SLM history index to data stream. Consequence of this is name change as name of data stream can't start with .. New name for SLM history data stream will be slm-history-4 (retaining version in the name). # Conflicts: # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/slm/history/SnapshotHistoryStore.java # x-pack/plugin/ilm/src/internalClusterTest/java/org/elasticsearch/xpack/slm/SLMSnapshotBlockingIntegTests.java
probakowski
added a commit
that referenced
this pull request
Nov 2, 2020
* Move SLM history to data stream (#63038) This change converts SLM history index to data stream. Consequence of this is name change as name of data stream can't start with .. New name for SLM history data stream will be slm-history-4 (retaining version in the name). # Conflicts: # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/slm/history/SnapshotHistoryStore.java # x-pack/plugin/ilm/src/internalClusterTest/java/org/elasticsearch/xpack/slm/SLMSnapshotBlockingIntegTests.java * fix compilation * Move SLM history back to hidden .slm-history (#64210) This change moves SLM history back to .slm-history pattern (with dot) and makes it hidden as we have hidden data streams now. * fix checkstyle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change converts SLM history index to data stream.
Consequence of this is name change as name of data stream can't start with
.. New name for SLM history data stream will beslm-history-4(retaining version in the name).