[DOCS] Extract the cron docs from Watcher docs and add to the API conventions.#56313
Merged
debadair merged 5 commits intoelastic:masterfrom May 12, 2020
Merged
[DOCS] Extract the cron docs from Watcher docs and add to the API conventions.#56313debadair merged 5 commits intoelastic:masterfrom
debadair merged 5 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-docs (>docs) |
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
|
💚 CLA has been signed |
11 tasks
33e4bd2 to
37117bf
Compare
jrodewig
approved these changes
May 12, 2020
Contributor
jrodewig
left a comment
There was a problem hiding this comment.
Looks good for the most part.
I believe we use a.m. and p.m. per the Elastic style guide. I left some other nits but
nothing I would consider blocking.
Thanks for taking care of this.
jrodewig
reviewed
May 12, 2020
Co-authored-by: James Rodewig <james.rodewig@elastic.co>
debadair
added a commit
to debadair/elasticsearch
that referenced
this pull request
May 12, 2020
…ventions. (elastic#56313) * [DOCS] Promote cron expressions info from Watcher to a separate topic. * Fix table error * Fixed xref * Apply suggestions from code review Co-authored-by: James Rodewig <james.rodewig@elastic.co> * Incorporated review feedback Co-authored-by: James Rodewig <james.rodewig@elastic.co>
debadair
added a commit
to debadair/elasticsearch
that referenced
this pull request
May 12, 2020
…ventions. (elastic#56313) * [DOCS] Promote cron expressions info from Watcher to a separate topic. * Fix table error * Fixed xref * Apply suggestions from code review Co-authored-by: James Rodewig <james.rodewig@elastic.co> * Incorporated review feedback Co-authored-by: James Rodewig <james.rodewig@elastic.co>
debadair
added a commit
to debadair/elasticsearch
that referenced
this pull request
May 12, 2020
…ventions. (elastic#56313) * [DOCS] Promote cron expressions info from Watcher to a separate topic. * Fix table error * Fixed xref * Apply suggestions from code review Co-authored-by: James Rodewig <james.rodewig@elastic.co> * Incorporated review feedback Co-authored-by: James Rodewig <james.rodewig@elastic.co>
debadair
added a commit
to debadair/elasticsearch
that referenced
this pull request
May 12, 2020
…ventions. (elastic#56313) * [DOCS] Promote cron expressions info from Watcher to a separate topic. * Fix table error * Fixed xref * Apply suggestions from code review Co-authored-by: James Rodewig <james.rodewig@elastic.co> * Incorporated review feedback Co-authored-by: James Rodewig <james.rodewig@elastic.co>
This was referenced May 12, 2020
debadair
added a commit
that referenced
this pull request
May 12, 2020
* [DOCS] Extract the cron docs from Watcher docs and add to the API conventions. (#56313) * [DOCS] Promote cron expressions info from Watcher to a separate topic. * Fix table error * Fixed xref * Apply suggestions from code review Co-authored-by: James Rodewig <james.rodewig@elastic.co> * Incorporated review feedback Co-authored-by: James Rodewig <james.rodewig@elastic.co> * [DOCS] Clarify definition of max_size (#56561) Co-authored-by: James Rodewig <james.rodewig@elastic.co>
debadair
added a commit
that referenced
this pull request
May 12, 2020
* [DOCS] Extract the cron docs from Watcher docs and add to the API conventions. (#56313) * [DOCS] Promote cron expressions info from Watcher to a separate topic. * Fix table error * Fixed xref * Apply suggestions from code review Co-authored-by: James Rodewig <james.rodewig@elastic.co> * Incorporated review feedback Co-authored-by: James Rodewig <james.rodewig@elastic.co> * [DOCS] Clarify definition of max_size (#56561) Co-authored-by: James Rodewig <james.rodewig@elastic.co>
debadair
added a commit
that referenced
this pull request
May 12, 2020
…ventions. (#56313) (#56652) * [DOCS] Promote cron expressions info from Watcher to a separate topic. * Fix table error * Fixed xref * Apply suggestions from code review Co-authored-by: James Rodewig <james.rodewig@elastic.co> * Incorporated review feedback Co-authored-by: James Rodewig <james.rodewig@elastic.co> Co-authored-by: James Rodewig <james.rodewig@elastic.co>
debadair
added a commit
that referenced
this pull request
May 12, 2020
…ventions. (#56313) (#56651) * [DOCS] Promote cron expressions info from Watcher to a separate topic. * Fix table error * Fixed xref * Apply suggestions from code review Co-authored-by: James Rodewig <james.rodewig@elastic.co> * Incorporated review feedback Co-authored-by: James Rodewig <james.rodewig@elastic.co> Co-authored-by: James Rodewig <james.rodewig@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up the changes from #49156, splits the cron expressions to a separate page, and adds the topic to the API conventions.
Based on the commits from #55953, will remove the WIP label once they've been merged.