[DOCS] Align with ILM changes.#55953
Conversation
|
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
|
Pinging @elastic/es-docs (>docs) |
| | `expire_after` | A timevalue for how old a snapshot must be in order to be eligible for deletion. | ||
| | `min_count` | A minimum number of snapshots to keep, regardless of age. | ||
| | `max_count` | The maximum number of snapshots to keep, regardless of age. |
There was a problem hiding this comment.
We're removing the description of these options, but I don't see them documented anywhere else now other than once in the example API request. I think we still need to document these configuration options somewhere
There was a problem hiding this comment.
They are in the API reference: https://github.com/elastic/elasticsearch/pull/55953/files#diff-3e796bf77f9921d05504be8c3e5a9349
Co-authored-by: Lee Hinman <dakrone@users.noreply.github.com>
| indices using the <<snapshot-restore,snapshots>> every day at a particular | ||
| time. Once these snapshots have been created, they are kept for a configured | ||
| amount of time and then deleted per a configured retention policy. | ||
| This tutorial demonstrates how to automate daily back ups of {es} indices using an {slm-init} policy. |
There was a problem hiding this comment.
This tutorial demonstrates how to
I thought we typically strayed away form this type of meta language. We could probably rephrase to something like You can use an {slim-init} policy to ...
There was a problem hiding this comment.
Tutorials are the one place the meta-info doesn't really bother me. I'm going to leave it for now & look at the language we use in other places. I'll open another PR to be consistent, one way or another. (With tutorial in the titles, it's not really necessary to repeat "tutorial" in the text for SEO purposes.)
jrodewig
left a comment
There was a problem hiding this comment.
+1 to @dakrone's feedback. I also left some suggestions needed formatting changes.
It may be a good idea to check out the preview of this one before publishing.
Most of the other comments are nits or things I wondered about. Those
aren't blocking and you can ignore if wanted.
Co-authored-by: James Rodewig <james.rodewig@elastic.co> Co-authored-by: Lee Hinman <dakrone@users.noreply.github.com>
|
@elasticmachine test this please |
* [DOCS] Align with ILM changes. * Apply suggestions from code review Co-authored-by: James Rodewig <james.rodewig@elastic.co> Co-authored-by: Lee Hinman <dakrone@users.noreply.github.com> * Incorporated review comments.
* [DOCS] Align with ILM changes. * Apply suggestions from code review Co-authored-by: James Rodewig <james.rodewig@elastic.co> Co-authored-by: Lee Hinman <dakrone@users.noreply.github.com> * Incorporated review comments.
* [DOCS] Align with ILM changes. * Apply suggestions from code review Co-authored-by: James Rodewig <james.rodewig@elastic.co> Co-authored-by: Lee Hinman <dakrone@users.noreply.github.com> * Incorporated review comments.
* [DOCS] Align with ILM changes. * Apply suggestions from code review Co-authored-by: James Rodewig <james.rodewig@elastic.co> Co-authored-by: Lee Hinman <dakrone@users.noreply.github.com> * Incorporated review comments.
No description provided.