value type, unmapped field, scripting tests for date range agg#55502
Closed
andyb-elastic wants to merge 1 commit intoelastic:mainfrom
Closed
value type, unmapped field, scripting tests for date range agg#55502andyb-elastic wants to merge 1 commit intoelastic:mainfrom
andyb-elastic wants to merge 1 commit intoelastic:mainfrom
Conversation
Adds tests for unmapped fields, supported values source types, and scripting. Moves some tests over from the integration test In AggregatorTestCase, skips asserting on the bucket consumer when collection did not occur, e.g. because of an unmapped field
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
26 tasks
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jul 29, 2022
This ports some of the tests for `date_range` from a high overhead `IntegTestCase` to a lower overhead `AggregatorTestCase`. `AggregatorTestCase` is also lower level so it can find more fun things like memory leaks. And it enables values source type testing for `date_range`. Inspired by elastic#55502 by andy.bristol@elastic.co
Member
|
Replaced by #88958. |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 1, 2022
This ports some of the tests for `date_range` from a high overhead `IntegTestCase` to a lower overhead `AggregatorTestCase`. `AggregatorTestCase` is also lower level so it can find more fun things like memory leaks. And it enables values source type testing for `date_range`. Inspired by #55502 by andy.bristol@elastic.co
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for unmapped fields, supported values source types, and
scripting. Moves some tests over from the integration test
In AggregatorTestCase, skips asserting on the bucket consumer when
collection did not occur, e.g. because of an unmapped field