Port tests for date_range#88958
Merged
elasticsearchmachine merged 2 commits intoelastic:mainfrom Aug 1, 2022
Merged
Conversation
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
This ports some of the tests for `date_range` from a high overhead `IntegTestCase` to a lower overhead `AggregatorTestCase`. `AggregatorTestCase` is also lower level so it can find more fun things like memory leaks. And it enables values source type testing for `date_range`. Inspired by elastic#55502 by andy.bristol@elastic.co
not-napoleon
approved these changes
Jul 29, 2022
Member
not-napoleon
left a comment
There was a problem hiding this comment.
LGTM, thanks for picking this up
Member
Author
|
@elasticmachine run elasticsearch-ci/packaging-tests-unix-sample |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports some of the tests for
date_rangefrom a high overheadIntegTestCaseto a lower overheadAggregatorTestCase.AggregatorTestCaseis also lower level so it can find more fun thingslike memory leaks. And it enables values source type testing for
date_range.Inspired by #55502 by andy.bristol@elastic.co