Skip to content

[DOCS] Collapse nested objects in graph-explore-api#55067

Merged
jrodewig merged 3 commits intoelastic:masterfrom
patelvp:docs/explore
Apr 13, 2020
Merged

[DOCS] Collapse nested objects in graph-explore-api#55067
jrodewig merged 3 commits intoelastic:masterfrom
patelvp:docs/explore

Conversation

@patelvp
Copy link
Copy Markdown
Contributor

@patelvp patelvp commented Apr 10, 2020

Summary
Collapsible docs for graph explore api document as mentioned in #54667
Uses changes in elastic/docs#1786

Tests
Ran ./gradlew -p docs check tests pass.

Closes #54667

@jtibshirani jtibshirani added :Analytics/Graph >docs General docs changes labels Apr 10, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Graph)

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-docs (>docs)

@jrodewig
Copy link
Copy Markdown
Contributor

@elasticmachine test this please

@jrodewig jrodewig self-requested a review April 10, 2020 17:47
Copy link
Copy Markdown
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @patelvp.

I left a few changes that need to be addressed along with explanations. Once those are addressed, I'll take another look. We appreciate your contributions!

@jrodewig
Copy link
Copy Markdown
Contributor

@elasticmachine test this please

@jrodewig
Copy link
Copy Markdown
Contributor

@patelvp I went ahead and merged some of my suggestions into this PR. This will let us close up #54667. I'll merge and backport the commit once the CI tests pass.

Thanks again for your contribution!

@jrodewig jrodewig merged commit 99c68e5 into elastic:master Apr 13, 2020
jrodewig added a commit that referenced this pull request Apr 13, 2020
Co-authored-by: James Rodewig <james.rodewig@elastic.co>
@jrodewig
Copy link
Copy Markdown
Contributor

Backport commits

master 99c68e5
7.x 16921eb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOCS] Implement collapsible sections for nested objects in Elasticsearch APIs

5 participants