Skip to content

[DOCS] Adds child_attributes CSS role#1786

Merged
lcawl merged 3 commits intoelastic:masterfrom
lcawl:child-attributes
Mar 26, 2020
Merged

[DOCS] Adds child_attributes CSS role#1786
lcawl merged 3 commits intoelastic:masterfrom
lcawl:child-attributes

Conversation

@lcawl
Copy link
Copy Markdown
Member

@lcawl lcawl commented Mar 25, 2020

This PR creates a stylesheet with a border around collapsed sections (detail/summary objects). It's intended for use in nested objects on API reference pages.

@lcawl lcawl force-pushed the child-attributes branch from f87d1f7 to 9cbb1dc Compare March 26, 2020 18:16
@lcawl lcawl removed the WIP label Mar 26, 2020
@lcawl lcawl marked this pull request as ready for review March 26, 2020 18:16
@lcawl lcawl changed the title [DOCS] Adds child_attribute CSS role [DOCS] Adds child_attributes CSS role Mar 26, 2020
@lcawl lcawl merged commit 6ad8146 into elastic:master Mar 26, 2020
@lcawl lcawl deleted the child-attributes branch March 26, 2020 18:34
@bmorelli25
Copy link
Copy Markdown
Member

bmorelli25 commented Apr 1, 2020

@lcawl, This is super cool! Question, would it be worth reconsidering the background color used for these collapsed sections? The color used, #fbfbfb is very similar to the color we use for inline code snippets: #f8f8f8. (Holy moly, how cool is it that GitHub automatically shows you the colors!)
Screen Shot 2020-04-01 at 11 15 13 AM

IMO, this makes it difficult to differentiate between inline code and regular text inside of collapsed sections. At the same time, code snippets are still monospaced, which does help, so I'm not sure how important this really is 🤷‍♂. Here's an example:
Screen Shot 2020-04-01 at 11 16 07 AM

@lcawl
Copy link
Copy Markdown
Member Author

lcawl commented Apr 1, 2020

@bmorelli25 Thanks for taking a look! As far as I'm concerned, improvements to the stylesheet are very welcome. I just copied the "sidebar" stylesheet then changed the blue outline to grey and minimized the padding. If you create a PR that makes it prettier or more easily to differentiate, I'm all for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants