Scripting: Deprecate general cache settings#55038
Merged
stu-elastic merged 23 commits intoelastic:masterfrom Apr 22, 2020
Merged
Scripting: Deprecate general cache settings#55038stu-elastic merged 23 commits intoelastic:masterfrom
stu-elastic merged 23 commits intoelastic:masterfrom
Conversation
…152-painless-limit-per-context__05__deprecate
…152-painless-limit-per-context__05__deprecate
…152-painless-limit-per-context__05__deprecate
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Scripting) |
…ns_rate=true in docker compose
stu-elastic
commented
Apr 17, 2020
| * Update a single context cache if we're in the context cache mode otherwise no-op. | ||
| */ | ||
| void updateContextSettings(Settings settings, ScriptContext<?> context) { | ||
| void set(String name, ScriptCache context) { |
Contributor
Author
There was a problem hiding this comment.
Rename to cache
stu-elastic
commented
Apr 20, 2020
| static class CacheHolder { | ||
| final ScriptCache general; | ||
| final Map<String, AtomicReference<ScriptCache>> contextCache; | ||
| void setCacheHolder(Settings settings, AtomicReference<CacheHolder> cacheHolder) { |
Contributor
Author
There was a problem hiding this comment.
Make this package protected.
…152-painless-limit-per-context__05__deprecate
jrodewig
reviewed
Apr 21, 2020
jrodewig
reviewed
Apr 21, 2020
rjernst
approved these changes
Apr 21, 2020
Contributor
Author
|
@elasticmachine run elasticsearch-ci/2 |
stu-elastic
added a commit
to stu-elastic/elasticsearch
that referenced
this pull request
Apr 23, 2020
* Test: don't modify defaultConfig on upgrade
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate and remove as fallback settings:
script.cache.max_sizein favor ofscript.context.$CONTEXT.cache_max_sizescript.cache.expirein favor ofscript.context.$CONTEXT.cache_expirescript.max_compilations_ratein favor ofscript.context.$CONTEXT.max_compilations_rateDefault to context cache.
Add
script.disable_max_compilations_rate, defaultfalseto totally disable compilation rates. This setting is intended for integration tests.Refs: #50152