Introduce aarch64 Docker image#53936
Merged
jasontedor merged 4 commits intoelastic:masterfrom Mar 23, 2020
Merged
Conversation
This commit introduces the infrastructure needed to build a Docker image for aarch64.
pugnascotia
approved these changes
Mar 23, 2020
Contributor
pugnascotia
left a comment
There was a problem hiding this comment.
These changes look good.
I wondered whether it was worth gathering the various bits of architecture-related data into a couple of enums? E.g. (incomplete):
public enum DockerArchitecture {
X_64("linux-x86_64", "centos:7", ""),
AARCH_64("linux-aarch64", "arm64v8/centos:7", "-arm64");
public final String classifier;
public final String dockerImage;
public final String tiniSuffix;
DockerArchitecture(String classifier, String dockerImage, String tiniSuffix) {
this.classifier = classifier;
this.dockerImage = dockerImage;
this.tiniSuffix = tiniSuffix;
}
}
jasontedor
added a commit
that referenced
this pull request
Mar 23, 2020
This commit introduces the infrastructure needed to build a Docker image for aarch64.
mark-vieira
reviewed
Mar 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces the infrastructure needed to build a Docker image for aarch64.
Relates #53914