Skip to content

Introduce aarch64 packaging#53914

Merged
jasontedor merged 7 commits intoelastic:masterfrom
jasontedor:aarch64
Mar 21, 2020
Merged

Introduce aarch64 packaging#53914
jasontedor merged 7 commits intoelastic:masterfrom
jasontedor:aarch64

Conversation

@jasontedor
Copy link
Copy Markdown
Member

@jasontedor jasontedor commented Mar 21, 2020 •
edited
Loading

This commit introduces aarch64 packaging, including bundling an aarch64 JDK distribution. We had to make some interesting choices here:

  • ML binaries are not compiled for aarch64, so for now we disable ML on aarch64
  • depending on underlying page sizes, we have to disable class data sharing

@jasontedor
Introduce aarch64 packaging
4b7aeb1 
This commit introduces aarch64 packaging, including bundling an aarch64
JDK distribution. We had to make some interesting choices here:
 - ML binaries are not compiled for aarch64, so for now we disable ML on
   aarch64 by default
 - depending on underlying page sizes, we have to disable class data
   sharing
@jasontedor jasontedor added release highlight :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts v8.0.0 v7.7.0 labels Mar 21, 2020
mark-vieira
mark-vieira approved these changes Mar 21, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boy, just shows how much boilerplate is involved here. There's probably room for improvement there but luckily we don't add new distribution types very often. LGTM 👍

FYI, we'll need to adapt the DistributionDownloadPlugin to the notion of an architecture as well once we want to start testing.

@jasontedor jasontedor merged commit 13f5631 into elastic:master Mar 21, 2020
@jasontedor jasontedor mentioned this pull request Mar 21, 2020
Merged
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Mar 21, 2020
@jasontedor
Introduce aarch64 packaging (elastic#53914)
4fc1e26 
This commit introduces aarch64 packaging, including bundling an aarch64
JDK distribution. We had to make some interesting choices here:
 - ML binaries are not compiled for aarch64, so for now we disable ML on
   aarch64
 - depending on underlying page sizes, we have to disable class data
   sharing
jasontedor added a commit that referenced this pull request Mar 22, 2020
@jasontedor
Introduce aarch64 packaging (#53914) (#53926)
27c8bcb 
This commit introduces aarch64 packaging, including bundling an aarch64
JDK distribution. We had to make some interesting choices here:
 - ML binaries are not compiled for aarch64, so for now we disable ML on
   aarch64
 - depending on underlying page sizes, we have to disable class data
   sharing
@jasontedor jasontedor deleted the aarch64 branch March 22, 2020 15:58
@jasontedor jasontedor mentioned this pull request Mar 22, 2020
Merged
drewr
drewr reviewed Mar 23, 2020
View reviewed changes
drewr
drewr reviewed Mar 23, 2020
View reviewed changes
distribution/archives/build.gradle
Comment on lines +191 to +192
archiveClassifier = 'linux-x86_64'
with archiveFiles(modulesFiles(true, 'linux'), 'tar', 'linux', 'x64', true, true)
Copy link
Copy Markdown
Contributor

@drewr drewr Mar 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy/paste error? I think these should be aarch64.

Copy link
Copy Markdown
Member Author

@jasontedor jasontedor Mar 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed 80c24a0 directly to address this. Thanks for noticing.

Copy link
Copy Markdown
Contributor

@drewr drewr Mar 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the archiveClassifier also need to be updated? I thought it would be linux-aarch64.

Copy link
Copy Markdown
Member Author

@jasontedor jasontedor Mar 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again. 🤦‍♀

I pushed ba431a0.

@davidkyle
Copy link
Copy Markdown
Member

davidkyle commented Mar 23, 2020

There is also the native controller to consider.

elasticsearch/server/src/main/java/org/elasticsearch/bootstrap/Spawner.java

Line 61 in e036ac4

void spawnNativeControllers(final Environment environment) throws IOException {

It looks like the process is launched then dies immediately. There will be no sign of this in the logs as no code will try to connect to the controller because xpack.ml.enabled: false and the process failure is not logged.

Perhaps extend the property in plugin.descriptor.properties to has.native.controller.x64 and has.native.controller. aarch64 or simply don't don't spawn the controller on aarch64

@jasontedor
Copy link
Copy Markdown
Member Author

jasontedor commented Mar 23, 2020

@davidkyle The spawner today has support for architectures, and skips trying to fork the native controller when it doesn't exist:

elasticsearch/server/src/main/java/org/elasticsearch/plugins/Platforms.java

Lines 50 to 54 in 91462ee

return plugin
.resolve("platform")
.resolve(PLATFORM_NAME)
.resolve("bin")
.resolve(PROGRAM_NAME);

elasticsearch/server/src/main/java/org/elasticsearch/plugins/Platforms.java

Line 88 in 91462ee

return normalizedOs + "-" + normalizedArch;

elasticsearch/server/src/main/java/org/elasticsearch/bootstrap/Spawner.java

Lines 75 to 78 in 91462ee

final Path spawnPath = Platforms.nativeControllerPath(modules);
if (!Files.isRegularFile(spawnPath)) {
continue;
}

This means that when run on aarch64, since there is not an ML native controller at x-pack-ml/platform/linux-aarch64/bin/controller, the spawner will not even attempt to fork a native controller.

@davidkyle
Copy link
Copy Markdown
Member

davidkyle commented Mar 23, 2020

👍 thanks for the explanation @jasontedor

@mark-vieira mark-vieira mentioned this pull request Mar 25, 2020
Closed
@tylersmalley tylersmalley mentioned this pull request Mar 26, 2020
Closed
This was referenced Apr 1, 2020
Closed
Closed
@james-crowley james-crowley mentioned this pull request Apr 7, 2020
Closed
@droberts195 droberts195 mentioned this pull request Apr 14, 2020
Merged
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
@droberts195 droberts195 mentioned this pull request Nov 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mark-vieira mark-vieira mark-vieira approved these changes

@rjernst rjernst Awaiting requested review from rjernst

+1 more reviewer

@drewr drewr drewr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts release highlight Team:Delivery Meta label for Delivery team v7.7.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jasontedor @davidkyle @drewr @mark-vieira @jakelandis