Remove xpack actions for the flattened field.#53076
Merged
jtibshirani merged 4 commits intoelastic:masterfrom Mar 4, 2020
Merged
Remove xpack actions for the flattened field.#53076jtibshirani merged 4 commits intoelastic:masterfrom
jtibshirani merged 4 commits intoelastic:masterfrom
Conversation
The current consensus is that we don't need info actions for smaller items like field mappers. We can also remove the usage action since the cluster stats API now tracks information about mappings, like what field types are defined.
Collaborator
|
Pinging @elastic/es-search (:Search/Mapping) |
jpountz
approved these changes
Mar 4, 2020
Contributor
jpountz
left a comment
There was a problem hiding this comment.
LGTM. I was going to talk to you about removing those today, but you've been too fast!
Contributor
Author
|
Thanks @jpountz ! A note that I only plan to commit to master, since it's a breaking change. |
Contributor
|
Yes, I checked the version labels when reviewing, this makes sense to me. |
mayya-sharipova
added a commit
to mayya-sharipova/elasticsearch
that referenced
this pull request
Jul 7, 2021
We have already decided not to have xpack usage for field mappers (see elastic#53076). As mappings stats of all fields is already tracked in cluster stats. Moreover xpack usage for vector field is a quite expensive operation (see elastic#74974). This removes xpack actions for vector field.
mayya-sharipova
added a commit
to mayya-sharipova/elasticsearch
that referenced
this pull request
Jul 13, 2021
We have already decided not to have xpack usage for field mappers (see elastic#53076). As mappings stats of all fields is already tracked in cluster stats. Moreover xpack usage for vector field is a quite expensive operation (see elastic#74974). This removes xpack actions for vector field. Backport for elastic#75017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current consensus is that we don't need info actions for smaller items like
field mappers. We can also remove the usage action since the cluster stats API
now tracks information about mappings, like what field types are defined.
Relates to #53071 and #51260.