Move analysis/mappings stats to cluster-stats.#51260
Merged
jpountz merged 6 commits intoelastic:masterfrom Feb 4, 2020
Merged
Conversation
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Stats) |
martijnvg
approved these changes
Jan 24, 2020
Member
martijnvg
left a comment
There was a problem hiding this comment.
Cluster stats doc snippet test needs to be adjusted, but otherwise LGTM!
| * Return the number of indices that use this feature across the cluster. | ||
| */ | ||
| public int getIndexCount() { | ||
| return indexCount; |
Member
There was a problem hiding this comment.
I think both count and indexCount are useful. Was there a specific reason why it wasn't included in the change to the xpack usage api initially?
Contributor
Author
There was a problem hiding this comment.
I mostly added statistics because the API name suggests so. I suspect that the number of clusters that used a field is going to be much more interesting than the number of indices or fields.
Contributor
Author
|
Thanks @martijnvg for looking! |
jpountz
added a commit
to jpountz/elasticsearch
that referenced
this pull request
Feb 4, 2020
jpountz
added a commit
that referenced
this pull request
Feb 5, 2020
jpountz
added a commit
to jpountz/elasticsearch
that referenced
this pull request
Feb 5, 2020
Now that elastic#51260 has been backported.
Merged
jpountz
added a commit
that referenced
this pull request
Feb 6, 2020
Now that #51260 has been backported.
This was referenced Apr 9, 2020
jrodewig
added a commit
that referenced
this pull request
Apr 17, 2020
PR #51260 moved usage counts about mapping field types and analysis to the `_cluster/stats` API. This documents those stats in the response section of the cluster stats API docs.
jrodewig
added a commit
that referenced
this pull request
Apr 17, 2020
PR #51260 moved usage counts about mapping field types and analysis to the `_cluster/stats` API. This documents those stats in the response section of the cluster stats API docs.
jrodewig
added a commit
that referenced
this pull request
Apr 17, 2020
PR #51260 moved usage counts about mapping field types and analysis to the `_cluster/stats` API. This documents those stats in the response section of the cluster stats API docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51138