Remove fixed_auto_queue_size threadpool type#52280
Merged
ywelsch merged 4 commits intoelastic:masterfrom Feb 14, 2020
Merged
Conversation
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
dakrone
requested changes
Feb 12, 2020
Member
dakrone
left a comment
There was a problem hiding this comment.
This removes too much, we still need a lot of the infrastructure from QueueResizingEsThreadPoolExecutor to gather the metrics required for adaptive replica selection.
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample-matrix-windows |
ywelsch
added a commit
that referenced
this pull request
Feb 14, 2020
This test broke after merging #52280.
ywelsch
added a commit
that referenced
this pull request
Feb 20, 2020
80 tasks
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Oct 4, 2021
The min and max queue resizing tests sometimes fail due to timing issues. Since the queue resizing is already removed for 8.0 (elastic#52280), there is less incentive to debug the flakiness. Given there are some other tests of queue resizing, and the feature is already removed in upcoming versions of ES, this commit removes the flaky tests. closes elastic#71476
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 4, 2021
The min and max queue resizing tests sometimes fail due to timing issues. Since the queue resizing is already removed for 8.0 (#52280), there is less incentive to debug the flakiness. Given there are some other tests of queue resizing, and the feature is already removed in upcoming versions of ES, this commit removes the flaky tests. closes #71476
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fixed_auto_queue_sizethread pool holds a fixed size of threads to handle the requests with a bounded queue for pending requests that have no threads to service them. It's similar to thefixedthreadpool, however, thequeue_sizeautomatically adjusts according to calculations based onLittle's Law. This dynamic adjustment was, by default, disabled for the two
fixed_auto_queue_sizethread pools (searchandsearch_throttled).As this feature was marked as experimental, and we are unaware of any users explicitly configuring this, we intent to deprecate it in ES 7 and remove it in ES 8.