Remove flaky queue resizing tests#78634
Merged
elasticsearchmachine merged 1 commit intoelastic:7.xfrom Oct 4, 2021
Merged
Conversation
The min and max queue resizing tests sometimes fail due to timing issues. Since the queue resizing is already removed for 8.0 (elastic#52280), there is less incentive to debug the flakiness. Given there are some other tests of queue resizing, and the feature is already removed in upcoming versions of ES, this commit removes the flaky tests. closes elastic#71476
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
dakrone
approved these changes
Oct 4, 2021
Member
dakrone
left a comment
There was a problem hiding this comment.
LGTM, I checked and we do have other tests for incrementing and decrementing the queue_size for this (test*Up and test*Down)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The min and max queue resizing tests sometimes fail due to timing
issues. Since the queue resizing is already removed for 8.0 (#52280),
there is less incentive to debug the flakiness. Given there are some
other tests of queue resizing, and the feature is already removed in
upcoming versions of ES, this commit removes the flaky tests.
closes #71476