EngineTestCase#getDocIds should use internal reader#49564
Merged
dnhatn merged 1 commit intoelastic:masterfrom Nov 26, 2019
Merged
EngineTestCase#getDocIds should use internal reader#49564dnhatn merged 1 commit intoelastic:masterfrom
dnhatn merged 1 commit intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Engine) |
Member
Author
|
Thanks Henning. |
dnhatn
added a commit
that referenced
this pull request
Nov 26, 2019
We do not guarantee that EngineTestCase#getDocIds is called after the engine has been externally refreshed. Hence, we trip an assertion assertSearcherIsWarmedUp. CI: https://gradle-enterprise.elastic.co/s/pm2at5qmfm2iu Relates #48605
dnhatn
added a commit
that referenced
this pull request
Nov 26, 2019
We do not guarantee that EngineTestCase#getDocIds is called after the engine has been externally refreshed. Hence, we trip an assertion assertSearcherIsWarmedUp. CI: https://gradle-enterprise.elastic.co/s/pm2at5qmfm2iu Relates #48605
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do not guarantee that EngineTestCase#getDocIds is called after the engine has been externally refreshed. Hence, we trip an assertion
assertSearcherIsWarmedUp.CI: https://gradle-enterprise.elastic.co/s/pm2at5qmfm2iu
Relates #48605