Do not warm up searcher in engine constructor#48605
Merged
dnhatn merged 4 commits intoelastic:masterfrom Oct 30, 2019
Merged
Conversation
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Engine) |
jpountz
reviewed
Oct 29, 2019
Contributor
jpountz
left a comment
There was a problem hiding this comment.
The change looks correct to me, but I'm not familiar enough with this part of the code to reason about potential implications, hopefully Henning or Yannick will be able to help here.
ywelsch
reviewed
Oct 29, 2019
Contributor
ywelsch
left a comment
There was a problem hiding this comment.
Left one comment, o.w. looking good
server/src/main/java/org/elasticsearch/index/engine/InternalEngine.java
Outdated
Show resolved
Hide resolved
henningandersen
approved these changes
Oct 29, 2019
Contributor
henningandersen
left a comment
There was a problem hiding this comment.
LGTM.
Left two minor comments to consider.
Member
Author
|
Thanks everyone for reviewing. |
dnhatn
added a commit
that referenced
this pull request
Oct 30, 2019
With this change, we won't warm up searchers until we externally refresh an engine. We explicitly refresh before allowing reading from a shard (i.e., move to post_recovery state) and during resetting. These guarantees that we have warmed up the engine before exposing the external searcher. Another prerequisite for #47186.
dnhatn
added a commit
that referenced
this pull request
Nov 3, 2019
With this change, we won't warm up searchers until we externally refresh an engine. We explicitly refresh before allowing reading from a shard (i.e., move to post_recovery state) and during resetting. These guarantees that we have warmed up the engine before exposing the external searcher. Another prerequisite for #47186.
dnhatn
added a commit
that referenced
this pull request
Nov 26, 2019
We do not guarantee that EngineTestCase#getDocIds is called after the engine has been externally refreshed. Hence, we trip an assertion assertSearcherIsWarmedUp. CI: https://gradle-enterprise.elastic.co/s/pm2at5qmfm2iu Relates #48605
dnhatn
added a commit
that referenced
this pull request
Nov 26, 2019
We do not guarantee that EngineTestCase#getDocIds is called after the engine has been externally refreshed. Hence, we trip an assertion assertSearcherIsWarmedUp. CI: https://gradle-enterprise.elastic.co/s/pm2at5qmfm2iu Relates #48605
dnhatn
added a commit
that referenced
this pull request
Nov 26, 2019
We do not guarantee that EngineTestCase#getDocIds is called after the engine has been externally refreshed. Hence, we trip an assertion assertSearcherIsWarmedUp. CI: https://gradle-enterprise.elastic.co/s/pm2at5qmfm2iu Relates #48605
This was referenced Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is another prerequisite for #47186.
With this change, we won't warm up searchers until we externally refresh an engine. We explicitly refresh before allowing reading from a shard (i.e., move to post_recovery state) and during resetting. These guarantees that we have warmed up the engine before exposing the external searcher.
Relates #47186