Handle failure to retrieve ILM policy step better#49193
Merged
Conversation
This commit wraps the calls to retrieve the current step in a try/catch so that the exception does not bubble up. Instead, step info is added containing the exception to the existing step. Semi-related to #49128
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
andreidan
reviewed
Nov 18, 2019
Contributor
There was a problem hiding this comment.
I think this generally looks good, but I am wondering if we need a special error handling in this particular case (policy missing/invalid step) or if we should instead use our existing execution halting and error reporting mechanism and move the lifecycle state into the ERROR step (ie. moveToErrorStep) ? A note on this is that these are the cases where the policy does exist. The case where it does not is handled separately by updating just the step info. @gwbrown what do you think?
Member
Author
|
We can’t actually move to the error step because it requires being able to
parse the policy correctly, in some/most cases though, the error is because
the policy couldn’t be parsed. That’s why I went with the step info rather
than ERROR step.
On Mon, Nov 18, 2019 at 4:17 AM Andrei Dan ***@***.***> wrote:
***@***.**** commented on this pull request.
I think this generally looks good, but I am wondering if we need a special
error handling in this particular case (policy missing/invalid step) or if
we should instead use our existing execution halting and error reporting
mechanism and move the lifecycle state into the ERROR step (ie.
moveToErrorStep) ? @gwbrown <https://github.com/gwbrown> what do you
think?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#49193?email_source=notifications&email_token=AAAEU5BO3BAU3HKVWIJKZQTQUJ2TJA5CNFSM4JN6HZUKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCL4DZ7Y#pullrequestreview-318258431>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAEU5AQ2ARQ3U74OR42Y63QUJ2TJANCNFSM4JN6HZUA>
.
|
AthenaEryma
approved these changes
Nov 18, 2019
Contributor
AthenaEryma
left a comment
There was a problem hiding this comment.
LGTM as well. I would like it if we could signal the error the same way as other policy errors as well, but I'm in favor of more visibility here as an improvement over the current situation since that's nontrivial.
Contributor
|
We will not backport this to 7.4 as a 7.5 release is imminent and there'll likely be no more 7.4.x releases |
andreidan
pushed a commit
to andreidan/elasticsearch
that referenced
this pull request
Nov 19, 2019
This commit wraps the calls to retrieve the current step in a try/catch so that the exception does not bubble up. Instead, step info is added containing the exception to the existing step. Semi-related to elastic#49128 (cherry picked from commit 72530f8) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
andreidan
pushed a commit
to andreidan/elasticsearch
that referenced
this pull request
Nov 19, 2019
This commit wraps the calls to retrieve the current step in a try/catch so that the exception does not bubble up. Instead, step info is added containing the exception to the existing step. Semi-related to elastic#49128 (cherry picked from commit 72530f8) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
This was referenced Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit wraps the calls to retrieve the current step in a try/catch
so that the exception does not bubble up. Instead, step info is added
containing the exception to the existing step.
Semi-related to #49128