[7.x] Un-mute locale depending mapping tests (#47977)#47983
[7.x] Un-mute locale depending mapping tests (#47977)#47983jkakavas wants to merge 8 commits intoelastic:7.xfrom
Conversation
Reverts 71968c9. The underlying issue which was related to the bouncycastle security provider permissions was resolved in elastic/infra#14995 resolves: elastic#39981
|
@elasticmachine test this please |
|
BWC tests fail because for 6.8.4 nodes we get @pgomulka any suggestions whether we should change the pattern in 7.x or simply disregard the warning ? |
|
If possible it would be great to migrate it to use recommended pattern. This will make future changes around dates easier. I am planning to refactor our tests to all use recommended patterns, but if you can fix this one that would help me a lot |
|
@pgomulka do you have any idea from the top of your head for how this should change ? Warning message said
but neither nor can be parsed in 6.8 nodes . |
|
@jkakavas in 6.8 the warning is created when new index with old joda style pattern is created. This is parsable in both 6.8 and 7+ |
|
however.. the behaviour of parsing is depending on jdk version. I noticed that locally on jdk 12 it was failing for me. Then I found this: https://stackoverflow.com/questions/46244724/jdk-dateformatter-parsing-dayofweek-in-german-locale-java8-vs-java9/46245412#46245412 Somehow this jdk option is not provided for this test? |
|
AFAICT, all nodes run with java 8 |
|
|
The main problem is to create a mapping with a locale and a format prefixed with |
It happens when a locale is specified on a mapping that a new JavaDateFormatter is created with a new mapping and already prefixed with 8 format is prefixed again. This should change avoids this behavior. relates #47983
|
ok to test |
|
@elasticmachine update branch |
|
@elasticmachine run elasticsearch-ci/default-distro |
|
@elasticmachine test this please again so that I can sleep well at night |
|
@elasticmachine run elasticsearch-ci/bwc |
|
@elasticmachine run elasticsearch-ci/default-distro |
|
@elasticmachine update branch |
|
@elasticmachine run elasticsearch-ci/bwc |
1 similar comment
|
@elasticmachine run elasticsearch-ci/bwc |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
|
^^ hmm... I would expect more CI jobs @elasticmachine test this ( all of this (no really all the jobs please ) ) please |
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
There are a lot of CI failures since the tests got unmuted. Example failure: Are you ok if I mute again until this gets looked at again? |
@dliappis let's mute this |
|
@jkakavas ACK |
Details in elastic#49719 Relates elastic#47983
|
Raised #49721 to mute the test |
Backports the following commits to 7.x: